Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ignore this PR #108

Closed
wants to merge 1 commit into from
Closed

Please ignore this PR #108

wants to merge 1 commit into from

Conversation

francoismassart
Copy link
Contributor

PR created just to be able to run coveralls (doesn't run on my local)

I'm curious to see if we could still use utils.triggerEvent() instead of el.click()

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.272% when pulling 8f197f6 on francoismassart:utils-triggerevent into 3f2a313 on wxsms:master.

@francoismassart
Copy link
Contributor Author

"Coverage remained the same" 🥇 , that means that utils.triggerEvent() can also work here, maybe we simply need the correct values for the bubbles and cancelable args.

@wxsms, do you think it is a good idea to find out the correct call using utils.triggerEvent() ?
This way, we could keep it consistent in all the spec files... WDYT ? Let me know and I'll find it out.

@wxsms
Copy link
Member

wxsms commented Nov 16, 2017

Hi. Thanks for the discovery. It seems working correctly with args set.

Actually the triggerEvent method is used to by pass some limitations of phantomjs before (sometimes focus() or something else can't trigger directly as usual).

I don't think that it is very necessary in keeping the event trigger test code consistent. Since they are just testings, it doesn't matter how to write them as long as they work as expect.

@francoismassart
Copy link
Contributor Author

Then we can ignore and close this one.

Did you see the other PR about the setSelection ?
#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants