feat: allow zipping hidden files by listing them explicitly in includeSources
#902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deSources` closes wxt-dev#604, fixes wxt-dev#738
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
approved these changes
Aug 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 82.30% 82.41% +0.10%
==========================================
Files 125 125
Lines 6538 6538
Branches 1093 1101 +8
==========================================
+ Hits 5381 5388 +7
+ Misses 1143 1136 -7
Partials 14 14 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 8, 2024
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I omitted
dot: trueand didn't touch the defaultexcludeSources(mentioned in #738 (comment)) to avoid filtering all files inside hidden directories (including those in.git). For example, in my repo:dot: truefilters 4657 filesIn theory, there should be no difference for the end user - both approaches will not include files inside the hidden directory if only that directory is specified in
includeSources(i.e. to include all files inside.hidden-dir, you should specify.hidden-dir/**, not.hidden-dir). Perhaps this specific aspect should be mentioned somehow in theincludeSourcesJSDoc?