-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotfiles cannot be included in the sources for Firefox #604
Labels
bug
Something isn't working
Comments
hikiko4ern
added
the
pending-triage
Someone (usually a maintainer) needs to look into this to see if it's a bug
label
Apr 6, 2024
This is probably a bug... I'll fix that at the same time. |
aklinker1
added
bug
Something isn't working
and removed
pending-triage
Someone (usually a maintainer) needs to look into this to see if it's a bug
labels
May 25, 2024
Released in |
Reverted in |
hikiko4ern
added a commit
to hikiko4ern/wxt
that referenced
this issue
Aug 4, 2024
…deSources` closes wxt-dev#604, fixes wxt-dev#738
Implemented correctly in #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Dotfiles cannot be included in a
sources.zip
usingincludeSources
(added in #378) after the changes made in #501:**/*
passed tofast-glob
doesn't match dotfiles withoutdot: true
, soincludeSources
doesn't actually affect anythingwxt/src/core/zip.ts
Line 102 in 6b72f88
To Reproduce
wxt-zip-env.zip
pnpm i
pnpm zip:firefox
.env
file is included in.output/wxt-starter-0.0.0-sources.zip
If you downgrade
wxt
to0.17.4
,.env
file will be included insources.zip
Expected behavior
The dotfiles specified in
includeSources
must be included insources.zip
Environment
Additional context
Since
includeSources
are already globs, perhaps it is enough to just add them to theglob
sources?However, I'm not sure why
options.include
is passed tozipDir
wxt/src/core/zip.ts
Lines 63 to 65 in 6b72f88
but actually
wxt.config.zip.includeSources
is used insteadwxt/src/core/zip.ts
Lines 110 to 113 in 6b72f88
The text was updated successfully, but these errors were encountered: