Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetNode.ts 的自动重连貌似有一句写错了的代码 #24

Closed
didoupt opened this issue Jan 12, 2021 · 6 comments
Closed

NetNode.ts 的自动重连貌似有一句写错了的代码 #24

didoupt opened this issue Jan 12, 2021 · 6 comments

Comments

@didoupt
Copy link

didoupt commented Jan 12, 2021

在NetNode.ts的第84行:
if (this._connectOptions == null) {
options.autoReconnect = options.autoReconnect
}
根据我我理解,宝爷在这里应该是想在第一次连接的时候设置自动重连的次数,所以正确的代码应该是这样色的:
if (this._connectOptions == null) {
this._autoReconnect = options.autoReconnect
}

@wyb10a10
Copy link
Owner

嗯,没错,要不要提个pr

@didoupt
Copy link
Author

didoupt commented Jan 12, 2021

额,我没有fork

@didoupt
Copy link
Author

didoupt commented Jan 12, 2021

我只是下载下来学习,偶然间发现的

@wyb10a10
Copy link
Owner

那我改一下?

@didoupt
Copy link
Author

didoupt commented Jan 12, 2021

好的,宝爷秒回,我好激动,啊哈哈哈

@wyb10a10
Copy link
Owner

已经修复,祝你生活愉快

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants