[merb-helpers] Use a helper method instead of a comment

wycats · Oct 15, 2009 · c4f4944 · c4f4944
1 parent 2c86bef
commit c4f4944
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/merb-helpers/lib/merb-helpers/form/builder.rb b/merb-helpers/lib/merb-helpers/form/builder.rb
@@ -375,8 +375,7 @@ def update_bound_controls(method, attrs, type)
 
     def update_unbound_controls(attrs, type)
       if attrs[:name] && !attrs[:id]
-        # '[' and ']' are illegal in HTML id attributes
-        attrs.merge!(:id => attrs[:name].to_s.gsub(/(\[|\])/, '_'))
+        attrs.merge!(:id => valid_xhtml_id(attrs[:name]))
       end
       case type
       when "text", "radio", "password", "hidden", "checkbox", "file"
@@ -385,6 +384,10 @@ def update_unbound_controls(attrs, type)
       super
     end
 
+    def valid_xhtml_id(candidate)
+      candidate.to_s.gsub(/(\[|\])/, '_')
+    end
+
     def radio_group_item(method, attrs)
       unless attrs[:id]
         attrs.merge!(:id => "#{@name}_#{method}_#{attrs[:value]}")