Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Fix error when inserting image into a span inside a list #777

Merged
merged 6 commits into from
Jan 28, 2016

Conversation

caffodian
Copy link
Contributor

There is a bug in the webkit span fixer code where when it is called on a span without a class, an error occurs. The most common place we see this is when inserting images into spans within lists. (Span alone causes the span to split, instead)

@winhamwr
Copy link
Member

a bug in the webkit span fixer code

Just to be clear, this bug exists with classless spans in any browser, right?

@winhamwr
Copy link
Member

This needs an item in the changelog. After that, it looks good.

Up for making a release or would you prefer to wait until the other insertion bug is fixed?

@caffodian
Copy link
Contributor Author

Just to be clear, this bug exists with classless spans in any browser, right?

It happens in Chrome, at least. The class attr is undefined and then toLowerCase gets called on it.

This needs an item in the changelog. After that, it looks good.

Up for making a release or would you prefer to wait until the other insertion bug is fixed?

Will do, still figuring out how to contribute. I haven't tracked down our other insertion bug yet, but I suspect that this fix also covers doing nearly anything inside a span (as long as the span doesn't get split by the command)

caffodian added a commit that referenced this pull request Jan 28, 2016
Fix error when inserting image into a span inside a list
@caffodian caffodian merged commit a696dd9 into wymeditor:master Jan 28, 2016
@caffodian caffodian deleted the classless_span branch January 28, 2016 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants