Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering twice on --prod version? #8

Closed
AhsanAyaz opened this issue Jul 13, 2018 · 19 comments
Closed

Rendering twice on --prod version? #8

AhsanAyaz opened this issue Jul 13, 2018 · 19 comments

Comments

@AhsanAyaz
Copy link

I'm having an issue with the grid items.
When running in dev env, it seems to work fine.
Also, building with --aot works fine.
But if I serve with --prod or build with --prod, the grid items are rendered twice :/

@nsksaisaravana
Copy link

I am also having the same issue. Please fix this.

@inshaf
Copy link

inshaf commented Aug 30, 2018

im also having the same issue :(

@inshaf
Copy link

inshaf commented Aug 31, 2018

any solutions ?

@nsksaisaravana
Copy link

+1

1 similar comment
@tempurai
Copy link

tempurai commented Sep 5, 2018

+1

@Murena7
Copy link

Murena7 commented Sep 20, 2018

Hello, quick solution to fix twice rendering in --prod mode is: set in angular.json "buildOptimizer": false.
This solution does not greatly increase the size, and works well.

@kolomu
Copy link

kolomu commented Sep 22, 2018

pure_getters from build optimizer is probably causing this issue. See: angular/angular-cli#11439 for more information or this link: angular/angular-cli#12096

@wynfred
Copy link
Owner

wynfred commented Oct 1, 2019

The issue should be fixed. Feel free to reopen if it's not.

@wynfred wynfred closed this as completed Oct 1, 2019
@nsksaisaravana
Copy link

@wynfred Thanks a lot, works like a charm. when are you going to upgrade to angular 7, 8, 9??

@wynfred
Copy link
Owner

wynfred commented Oct 2, 2019

@nsksaisaravana The current version should work with v7 and v8. I think it should work with v9 and IVY as well, and I'll do more testing after the official v9 is released.

@wynfred
Copy link
Owner

wynfred commented Oct 17, 2019

Reopen because same issue was reported by #26

@wynfred wynfred reopened this Oct 17, 2019
@madmacc
Copy link

madmacc commented Oct 28, 2019

The fix above by @Murena7 worked for me as an interim solution.

Hello, quick solution to fix twice rendering in --prod mode is: set in angular.json "buildOptimizer": false.
This solution does not greatly increase the size, and works well.

@wynfred
Copy link
Owner

wynfred commented Oct 29, 2019

@madmacc Just FYI, if you have an app in production, turning off buildOptimizer is not a good idea, unless you are fine with the change of bundle size.

@madmacc
Copy link

madmacc commented Oct 29, 2019

@wynfred True. I ended up using your other suggestion and turning off the animation and using my own angular animations.

masonryOptions: NgxMasonryOptions = {
    transitionDuration: '0'
  };

@flodaniel
Copy link

any update on this? does anybody have a suggestions to keep the animations and fix this? :)

@wynfred
Copy link
Owner

wynfred commented Apr 15, 2020

Hopefully this fixes the animation issue. I'd appreciate if you can help test the new release and report issues if there are.
https://github.com/wynfred/ngx-masonry#animations

@wynfred wynfred closed this as completed Apr 15, 2020
@webcat12345
Copy link

@wynfred I really like your last update v9, that's amazing, just leaving this comment here, coz this is the only way to send you a message :) You are awesome 👍

@wynfred
Copy link
Owner

wynfred commented May 15, 2020

@webcat12345 glad to hear that 😄

@rozzs74
Copy link

rozzs74 commented Aug 19, 2020

Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests