Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Boost? #4

Open
wztzjhn opened this issue Jul 8, 2022 · 2 comments
Open

remove Boost? #4

wztzjhn opened this issue Jul 8, 2022 · 2 comments

Comments

@wztzjhn
Copy link
Owner

wztzjhn commented Jul 8, 2022

The only place for Boost here is only a root solver, which can be replaced by a simple hand-coded binary search: the density versus mu function is monotonic.

Similarly, the Boost dependency in Kondo repo can be removed, since c++17 already supports "filesystem". Standing at 2022, c++17 is quite well implemented in major compilers.

This may greatly reduce the installation barrier for many users (boost filesystem never worked out of the box in most the HPC's in my experience, always requireed a manual installation).

@kbarros
Copy link
Collaborator

kbarros commented Jul 9, 2022

This seems like a good idea to me. I think Boost was more needed in the Kondo repo, for things like file/directory access?

@wztzjhn
Copy link
Owner Author

wztzjhn commented Jul 9, 2022

The file/directory access is included in c++17 in std::filesystem. So if we require c++17 instead of c++11, we can replace all boost::filesystem by std::filesystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants