Defer reflective access to Java core modules (1.4) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famod
commented
Aug 12, 2020
| } | ||
| getName = method; | ||
| } | ||
| private static final Map instanceMaps = Collections.synchronizedMap(new HashMap()); |
There was a problem hiding this comment.
Semantically, a synchronized map is (of course) not the same as ConcurrentHashMap with .computeIfAbesent() (like in master) but it should be sufficient to prevent illegal concurrent access.
The drop in efficiency should be tolerable.
|
Merged. Thanks for contribution. |
|
@joehni Thank you very much for releasing 1.4.13 with this workaround! |
|
Thanks for your contribution. Now that it is available on Central, I can finally send the announcement... ;-) |
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Sep 8, 2020
Fixes quarkusio#10303 for some cases when using JUnit5 ParameterResolver. Includes x-stream/xstream#218 that tries to avoid such warnings at XStream creation time. Also adds xstream to dependabot. Comment regardings optaplanner was outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of 3cec78d as discussed here: #216 (comment)
Relates to #101 and quarkusio/quarkus#10303 (comment)