Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is the subheading attribute supposed to work? #7

Closed
sole opened this issue Mar 18, 2014 · 4 comments
Closed

How is the subheading attribute supposed to work? #7

sole opened this issue Mar 18, 2014 · 4 comments
Labels

Comments

@sole
Copy link
Contributor

sole commented Mar 18, 2014

The current demo doesn't show the content of the subheading attribute anywhere, instead it is set up as an attribute of the h1. Are we supposed to conjure attr magic in order to show the content?

Or is this a bug? :)

I'm specifically referring to this demo: https://github.com/x-tag/appbar/blob/master/demo/testpage.html

@sole sole added bug labels Mar 18, 2014
@pennyfx
Copy link
Member

pennyfx commented Mar 18, 2014

Yes, we used attr by design. We didn't really see the point of creating another element inside or along side the H1 for the subheading. The :after pseudo element gave it to us for free.

The subheading is shown in the 3rd example.

https://www.dropbox.com/s/3kkf0v2jigqd1pu/Screen%20Shot%202014-03-18%20at%2012.56.12%20PM.png

@pennyfx pennyfx removed the bug label Mar 18, 2014
@sole
Copy link
Contributor Author

sole commented Mar 19, 2014

You're running some sort of voodoo magic here because I can't see any subheading in my side :-)

screen shot 2014-03-19 at 11 13 20

Besides, I don't even see a rule for :after using attr here: https://github.com/x-tag/appbar/blob/master/src/appbar.css

Am I missing something? Are you using a different version? :D

@pennyfx
Copy link
Member

pennyfx commented Mar 19, 2014

You're right, potch removed it! @potch!!!!! 7333ddc#diff-441557000352b0ffdf03f4c2d3c6685d

@pennyfx
Copy link
Member

pennyfx commented Mar 21, 2014

Fixed. d62114a

@pennyfx pennyfx closed this as completed Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants