Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render() Recursion Error #182

Closed
ghost opened this issue Oct 7, 2017 · 3 comments
Closed

Render() Recursion Error #182

ghost opened this issue Oct 7, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2017

V2 Build with a recursion error is ==> https://kipomaha.github.io/x-tag-setup/tests/basic/index.html

Tested on multiple browsers including some older fossils but I believe that the Jasmine test I've got built here demonstrates it just fine. The recursion error only occurs when a custom element is inserted in to the dom.

@csuwildcat
Copy link
Member

Ok, this is the spec section 2.2 stuff I suspected. Today I talked with a couple Google friends and they said to do in-source testing because it was probably a difference between the parser flow and the dynamically created element flow. I need to move the onConstruct hook out of the constructor and figure something else out if we want to maintain the automatic construction/render part.

@csuwildcat
Copy link
Member

Thank you for confirming with the test case!

@ghost
Copy link
Author

ghost commented Oct 7, 2017

Your welcome @csuwildcat,
I've made a pull request with comments for V2 and a change to the render() method. The change is just a quick fix, I like the behavior though because it allows you to use the auto-render feature and doesn't clear the innerHTML so you can use render multiple templates.

You still get a recursive error whenever you set content with this.innerHTML, so it still is an issue.

@ghost ghost changed the title Recursion Error Render() Recursion Error Oct 7, 2017
@ghost ghost closed this as completed Oct 17, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant