Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (PersistedEntityInstanceCache): CountOf fixed to support counting interface types #448

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Ibrahim5aad
Copy link
Member

This PR helps in solving #434.

when using and Esent model provider the count of method of the persisted cache throws exception when counting interface types because the implementation supported only getting the corresponding express types of classes.

  • Name of this PR is aligned with the name the story.
  • It compiles and runs for everybody.
  • New code is covered by tests
  • All tests run and pass
  • Code is readable
  • Amount of changes is understandable
  • It does what is says it does. I have checked that.

…g interface types

when using and esent model provider the count of method of the persisted cache throws exception when counting interface types because the implementation supported only getting the corresponding express types of classes
@Ibrahim5aad Ibrahim5aad self-assigned this Oct 12, 2022
@Ibrahim5aad Ibrahim5aad added bug Confirmed bug esent Issues relating to the windows only esent data store labels Oct 12, 2022
@martin1cerny martin1cerny merged commit 8bbd7fb into develop Oct 20, 2022
@martin1cerny martin1cerny deleted the fix/persisted-cache-count-fix branch October 20, 2022 06:55
@martin1cerny
Copy link
Member

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug esent Issues relating to the windows only esent data store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants