Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Could you please adapt this to hexo-material-theme? #1

Closed
rosuH opened this issue Aug 10, 2017 · 1 comment
Closed

[Question] Could you please adapt this to hexo-material-theme? #1

rosuH opened this issue Aug 10, 2017 · 1 comment

Comments

@rosuH
Copy link

rosuH commented Aug 10, 2017

Thanks for your excellent work and I love it so much. However I can't apply this to my hexo-site.
I am using hexo-material-theme and I had tried to ported it by myself but I failed.
Thought I do konw nothing about WebDev, I tried to followed your guide and hexo-material-theme comment adaptation guide but get some worng:

ERROR Script load failed: themes/Material/scripts/lib/Valine.min.js
ReferenceError: window is not defined
    at /mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:19484
    at /mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:19439
    at n.exports (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:19939)
    at Object.<anonymous> (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:2732)
    at e (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:390)
    at Object.<anonymous> (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:3204)
    at e (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:390)
    at Object.defineProperty.value (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:773)
    at /mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:782
    at t (/mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:146)
    at /mnt/d/Documents/Blog/themes/Material/scripts/lib/Valine.min.js:1:267
    at /mnt/d/Documents/Blog/node_modules/hexo/lib/hexo/index.js:232:12
    at tryCatcher (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise._fulfill (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:638:18)
    at Promise._resolveCallback (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:432:57)
    at Promise._settlePromiseFromHandler (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:524:17)
    at Promise._settlePromise (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/mnt/d/Documents/Blog/node_modules/bluebird/js/release/promise.js:614:10)

Here is my environment Info:

hexo: 3.3.8
hexo-cli: 1.0.3
os: Linux 4.4.0-43-Microsoft linux x64
http_parser: 2.7.0
node: 8.1.4
v8: 5.8.283.41
uv: 1.12.0
zlib: 1.2.11
ares: 1.10.1-DEV
modules: 57
openssl: 1.0.2l
icu: 59.1
unicode: 9.0
cldr: 31.0.1
tz: 2017b

├── hexo@3.3.8
├── hexo-deployer-git@0.3.1
├── hexo-directory-category@1.0.3
├── hexo-filter-auto-spacing@0.2.1
├── hexo-generator-archive@0.1.4
├── hexo-generator-category@0.1.3
├── hexo-generator-index@0.2.1
├── hexo-generator-search@2.1.1
├── hexo-generator-tag@0.2.0
├── hexo-prism-plugin@2.1.2
├── hexo-renderer-ejs@0.2.0
├── hexo-renderer-marked@0.2.11
├── hexo-renderer-stylus@0.3.3
└── hexo-server@0.2.2

May be you can give me some suggestion or do it by yourself out of kindness.
My English is poor and I can provide Chinese version if you want.
Thanks again.

@xCss
Copy link
Owner

xCss commented Aug 10, 2017

@rosuH 昨天已经提交了hexo-material-theme的PR

具体请查看#478 #480

使用的时候请更新Valine版本为1.1.3

或直接使用cdn:https://cdn.jsdelivr.net/npm/valine@1.1.3/dist/Valine.min.js

@rosuH rosuH closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants