-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flake8 error code format #5
Comments
In principle yes, but to be honest there are only so much letters (aka 26) and so it's problematic to use another letter. But maybe it's possible to share the same letter, especially as my plugin is similar to flake8-import-order. And an opt-in flag would certainly be possible but the question is what other prefix. Making it completely free would probably cause to much confusion, but in case I'm going to change it, it is probably sensible. Although I don't consider it finished and so users should expect that the format changes (maybe with a grace period where it's possible to opt-in into the new first, then opt-out into the old). |
I suspect this might also be the reason the flake8-linter for Atom does not display the violations raised by this plugin. Following their code is difficult for me, but I think perhaps this regex is the issue... |
@xZise It is possible to share codes with other projects. For example |
I actually need to retract this comment because @sigmavirus24's response there isn't speaking for the project itself. But it still leaves the issue that I don't really like to "just" use another project's error code space without coordinating with them. And I agree with the following sentiment:
|
Hi, as noted in the documentation of Flake8 itself, the code can be build from up to three letters. As such I'd prefer to stay with the current format for now. |
flake8 defines warning and error codes as "an upper case ASCII letter followed by three digits" (http://flake8.readthedocs.org/en/latest/warnings.html). FI## doesn't fit this format.
I ran into the issue with Jenkins' Violations plugin which uses a strict regex which doesn't match the FI## pattern (https://github.com/jenkinsci/violations-plugin/blob/cab7103b/src/main/java/hudson/plugins/violations/types/pep8/Pep8Parser.java#L41).
Would you be open to changing the error code format? Possibly using an opt-in flag to avoid to not break existing configurations.
The text was updated successfully, but these errors were encountered: