Skip to content

Commit

Permalink
Issue mozilla#25 - addressed comments, part 2:
Browse files Browse the repository at this point in the history
- move <prefwindow> styling to titlebar.css
- avoid defaultView.window
- no space between named function and "("
  • Loading branch information
xabolcs committed Jul 9, 2012
1 parent ba06511 commit 66c0392
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions extension/chrome/content/titlebar/customize.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function arrayBasedTreeView (treeViewData) {
arrayBasedTreeView.prototype = {
data: [],

get rowCount () {
get rowCount() {
return this.data.length;
},

Expand Down Expand Up @@ -95,7 +95,7 @@ variables: [],

init: function(aEvent)
{
aEvent.originalTarget.defaultView.window.removeEventListener("load", paneTitle.init, false);
aEvent.originalTarget.defaultView.removeEventListener("load", paneTitle.init, false);

var mediator = Components.classes['@mozilla.org/appshell/window-mediator;1']
.getService(Components.interfaces.nsIWindowMediator);
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/content/titlebar/customize.xul
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

<prefwindow id="NightlyTesterOptions" windowtype="NightlyTester:Customize"
title="&nightly.customize.title;"
style="width: 42.75em; height: 28.5em" persist="width height"
persist="width height"
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

<prefpane id="paneTitle" label="&nightly.customize.title;" flex="1">
Expand Down
3 changes: 3 additions & 0 deletions extension/chrome/skin/titlebar/titlebar.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@
#variableTree {
height: 17em;
}
#NightlyTesterOptions {
width: 42.75em;
}

0 comments on commit 66c0392

Please sign in to comment.