Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve resource cleanup for python operation #281

Closed
XaF opened this issue Dec 11, 2023 · 0 comments · Fixed by #282
Closed

improve resource cleanup for python operation #281

XaF opened this issue Dec 11, 2023 · 0 comments · Fixed by #282
Labels
enhancement New feature or request
Milestone
v0.0.18

Comments

@XaF
Copy link
Owner

XaF commented Dec 11, 2023

Since the last update to the python operation, we are cleaning up the work directory data path of untouched resources as we create new resources. However, this would fail in a situation where we have more than one python operation being called, as the latest would cleanup the resources of any other python operation before.

We thus need to:

  • Remove the cleanup as part of those steps
  • Handle a proper resource cleanup at the end of the up command (as part of the cleanup of unused resources)

We also want to add workdir cleanup of the data path on omni down.
@XaF XaF added the enhancement New feature or request label Dec 11, 2023
@XaF XaF added this to the v0.0.18 milestone Dec 11, 2023
XaF added a commit that referenced this issue Dec 13, 2023
@XaF
feat(up tools): ✨ better cleanup for data paths
8c1cf0c 
#277 introduces venv creation and
was handling the deletion as part of the venv setup, which did not
allow to handle multiple versions of python at the same time,
except while using `auto`.

This fixes that by moving the data path cleanup to the cleanup
process that handles removing unused versions at the end of
an `omni up` or `omni down`.

This also means that it naturally handles the removal of the work
directory data path as part of the `omni down` process.

Closes #281
@XaF XaF mentioned this issue Dec 13, 2023
Merged
@XaF XaF closed this as completed in #282 Dec 13, 2023
XaF added a commit that referenced this issue Dec 13, 2023
@XaF
feat(up tools): ✨ better cleanup for data paths (#282)
8283422 
#277 introduced venv creation and was
handling the deletion as part of the venv setup, which did not allow to
handle multiple versions of python at the same time, except while using
`auto`.

This fixes that by moving the data path cleanup to the cleanup process
that handles removing unused versions at the end of an `omni up` or
`omni down`.

This also means that it naturally handles the removal of the work
directory data path as part of the `omni down` process.

Closes #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.18
Development

Successfully merging a pull request may close this issue.

feat(up tools): ✨ better cleanup for data paths XaF/omni
1 participant
@XaF