Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish shell integration uses an absolute path for $HOME #7

Closed
tminusplus opened this issue Jun 23, 2023 · 2 comments
Closed

Fish shell integration uses an absolute path for $HOME #7

tminusplus opened this issue Jun 23, 2023 · 2 comments

Comments

@tminusplus
Copy link
Contributor

Noticed that the Fish shell integration uses an absolute path, instead of a variable, to refer to the home directory:

❯ cat ~/.config/fish/conf.d/omni.fish
test -f "/Users/tszucs/git/XaF/omni/shell_integration/omni.fish"; and source "/Users/tszucs/git/XaF/omni/shell_integration/omni.fish"

This means that syncing my fish config to another computer (ex. Mac -> Linux) will break the fish config, if the home directory or user is different. I did not check the other shell integrations.

@XaF
Copy link
Owner

XaF commented Jun 23, 2023

I think you are still using the old integration which provided the full file. New integration should be as simple as:

omni hook init fish | source

Anywhere in your fish configuration.
Am I missing something else?

@tminusplus
Copy link
Contributor Author

tminusplus commented Jun 26, 2023

That is right, it was a leftover from the Ruby version's install. PEBCAK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants