Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: '%s' is not supported by the datetime module #92

Closed
XaF opened this issue Apr 19, 2018 · 0 comments
Closed

Windows: '%s' is not supported by the datetime module #92

XaF opened this issue Apr 19, 2018 · 0 comments
Assignees
@XaF
Labels
OS: Windows Issues that impact Windows

Comments

@XaF
Copy link
Owner

XaF commented Apr 19, 2018 •
edited
Loading

TraktForVLC relies on the data command of the Python helper to get the current timestamp. However, the datetime Python module for WIndows does not support the '%s' format, which leads to failures of TraktForVLC, as reported in issue #91 by @Ale46.

[000000000264bb90] [trakt] main interface error: connection failed: Connection refused by peer
[000000000264bb90] [trakt] lua interface error: (call_helper) Command: "date" "--format" "%s.%f"
[000000000264bb90] [trakt] lua interface error: (call_helper) Command exited with code -1
@XaF XaF self-assigned this Apr 19, 2018
XaF added a commit that referenced this issue Apr 19, 2018
@XaF
helper: commands: date: workaround the missing '%s' on Windows
b0c65b1 
Python does not support the '%s' format string for the datetime
module on Windows. This patch fixes that behavior by replacing
the '%s' string by the value returned by 'time.time()' on
Windows only; keeping the old behavior for Linux and MacOS.

Fixes #92

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
@XaF XaF added the OS: Windows Issues that impact Windows label Apr 19, 2018
@XaF XaF mentioned this issue Apr 19, 2018
Merged
@XaF XaF closed this as completed in 74c2daa Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XaF XaF

Labels
OS: Windows Issues that impact Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XaF