Windows batch scripts fix #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaPro
commented
Sep 14, 2016
AndreaPro
commented
- All batchscripts were almost unreadable inside Windows default text editor, and even if the first line was commented the command prompt was giving a strange error, so I've converted all the scripts from UTF-8 and Unix EOL to ANSI PC EOL so this fixed the errors and make them readable with te correct CR and LFs.
- The "set_registry_keys.bat" was malfunctioning, it worked well only if VLC 64 bit is used, because under windows the last parenthesis in Program Files (x86) was causing the FOR loop to quit before executing the lines of code inside. To fix this I've used DelayedExpansion so now the script should work with VLC in any path. To make the script work I've also edited the "config.bat.default" file.
- Edited README.md to reflect changes made in batch scripts
…f VLC 64 bit is used, because under windows the last parenthesis in Program Files (x86) was causing the FOR loop to quit before executing the lines of code inside. To fix this I've used DelayedExpansion so now the script should work with VLC in any path. To make the script work I've also edited the "config.bat.default" file.
…ditor, and even if the first line was commented the command prompt was giving a strange error, so I've converted all the scripts from UTF-8 and Unix EOL to ANSI PC EOL so this fixed the errors and make them readable with te correct CR and LFs.
|
Will need other users' confirmations before merging this patch, as I can't directly try it myself at the moment! |
XaF
force-pushed
the
master
branch
2 times, most recently
from
dd53221
to
93df81b
Compare
|
TraktForVLC 2.x makes that PR obsolete - #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.