clean out Aten, SNT, netfx #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2020
Closed
Closed
|
Note it's possible someone might want to resurrect the System.Numerics.Tensor/AtenSharp bindings, but these should I think be in a separate repo. |
|
I am archiving the AtenSharp and STN portions of this repository at https://github.com/fsprojects/AtenSharp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion with @interesaaat we propose the following to simplify this repo
Remove AtenSharp. The PyTorch C++ API is now the correct layer to wrap
Remove the SNT implementation built on ATenSharp. It is better if this repo focus on the TorchTensor layer wrapping the PyTorch 1.5 C++ API
Remove .NET Framework support
Always build for both netstandard 2.1 and netcoreapp3.0 (i.e. with intrinsics support)
See issue #128
Also addresses #67 - copyright notices