Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] LineBreakMode for Button #3106

Closed
peterfoot opened this issue Jun 21, 2018 · 5 comments · Fixed by #11147
Closed

[Enhancement] LineBreakMode for Button #3106

peterfoot opened this issue Jun 21, 2018 · 5 comments · Fixed by #11147
Labels
F100 in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕
Projects
v4.3.0 v4.6.0 .NET MAUI Backlog

Comments

@peterfoot
Copy link
Contributor

##Summary
Add LineBreakMode (as currently supported on Label) to the Button control to specify text wrapping/trimming behavior. I've created an implementation as an Effect here:-
https://github.com/inthehand/InTheHand.Forms/blob/master/InTheHand.Forms/ButtonLineBreakModeEffect.cs

##API Changes

Addition of LineBreakMode property on Button. Use existing LineBreakMode enum.

##Intended Use Case
Allows you to specify the linebreak/wrapping appearance for Buttons rather than reverting to different default platform specific appearances.
@pauldipietro pauldipietro added this to New in Triage Jun 21, 2018
@samhouts
Copy link
Member

related to #1668

@samhouts samhouts removed this from New in Triage Jun 21, 2018
@jfversluis jfversluis mentioned this issue Jul 13, 2018
Closed
@yunusefendi52 yunusefendi52 mentioned this issue Oct 9, 2018
Closed
3 tasks
@samhouts samhouts added this to In Progress in v3.6.0 Oct 9, 2018
@velocitysystems
Copy link
Contributor

@samhouts Would you like a PR for this? We've already implemented this on iOS, Android and UWP.
If I put up a PR, can probably do the other platforms too.

@samhouts samhouts removed this from In Progress in v3.6.0 Feb 2, 2019
@samhouts
Copy link
Member

samhouts commented Feb 4, 2019

@velocitysystems Yes! That would be great! Thank you!

@samhouts samhouts added this to Under consideration in Enhancements Feb 5, 2019
@samhouts samhouts moved this from Under consideration to Needs Specification in Enhancements Feb 6, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Aug 3, 2019
@samhouts samhouts added this to In Progress in v4.3.0 Aug 3, 2019
@samhouts samhouts removed this from Needs Specification in Enhancements Aug 3, 2019
@pictos pictos mentioned this issue Oct 4, 2019
Closed
2 tasks
@pictos
Copy link
Contributor

pictos commented Oct 4, 2019

@samhouts since the #7043 already has a PR, I want to work on this issue. I'll send a draft PR for this.

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Oct 4, 2019
@samhouts samhouts added this to In Progress in v4.4.0 Oct 4, 2019
@samhouts samhouts removed the inactive Issue is older than 6 months and needs to be retested label Oct 7, 2019
@FIELDPOINT
Copy link

Any updates on this?

@samhouts samhouts added this to In Progress in v4.5.0 Nov 2, 2019
@samhouts samhouts removed this from In Progress in v4.4.0 Nov 2, 2019
@samhouts samhouts added this to In Progress in v4.6.0 Jan 10, 2020
@samhouts samhouts added proposal-open and removed help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 7, 2020
@samhouts samhouts removed this from In Progress in v4.5.0 Feb 13, 2020
@PureWeen PureWeen mentioned this issue Feb 21, 2020
Closed
@pictos pictos mentioned this issue Feb 26, 2020
Closed
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Mar 19, 2020
@pictos pictos mentioned this issue Jun 20, 2020
Merged
2 tasks
rmarinho added a commit to pictos/Xamarin.Forms that referenced this issue Jul 1, 2020
@rmarinho
Merge branch 'main' into xamaringh-3106
a360e39
pictos added a commit to pictos/Xamarin.Forms that referenced this issue Jul 23, 2020
@pictos
Merge branch 'main' into xamaringh-3106
3cec083
@samhouts samhouts added this to In Progress in .NET MAUI Backlog Jul 30, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020
.NET MAUI Backlog automation moved this from In Progress to Done Sep 1, 2020
samhouts pushed a commit that referenced this issue Sep 1, 2020
@pictos
GH-3106 Implemented LineBreakMode to Button (#11147)
17881ec 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes #3106
rmarinho pushed a commit that referenced this issue Sep 2, 2020
@pictos @rmarinho
GH-3106 Implemented LineBreakMode to Button (#11147)
e03f443 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes #3106
pictos added a commit to pictos/Xamarin.Forms that referenced this issue Sep 12, 2020
@pictos
xamarinGH-3106 Implemented LineBreakMode to Button (xamarin#11147)
2bfb893 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes xamarin#3106
domagojmedo pushed a commit to domagojmedo/Xamarin.Forms that referenced this issue Sep 12, 2020
@pictos
xamarinGH-3106 Implemented LineBreakMode to Button (xamarin#11147)
89ad57e 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes xamarin#3106
pictos added a commit to pictos/Xamarin.Forms that referenced this issue Sep 12, 2020
@pictos
xamarinGH-3106 Implemented LineBreakMode to Button (xamarin#11147)
441e2a3 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes xamarin#3106
jsuarezruiz pushed a commit that referenced this issue Sep 17, 2020
@pictos @jsuarezruiz
GH-3106 Implemented LineBreakMode to Button (#11147)
c3dabea 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes #3106
shyunMin pushed a commit to shyunMin/Xamarin.Forms that referenced this issue Feb 19, 2021
@pictos @rookiejava
xamarinGH-3106 Implemented LineBreakMode to Button (xamarin#11147)
9c46f7b 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes xamarin#3106
Axemasta pushed a commit to Axemasta/Xamarin.Forms that referenced this issue Apr 5, 2021
@pictos @Axemasta
xamarinGH-3106 Implemented LineBreakMode to Button (xamarin#11147)
76ecd46 
* Added LineBreakMode in the Button and TestAttributes

* Added LineBreakMode implementation on Android platform

* Added Issue into the Controls project

* Removed unused method

* Added UWP support for LineBreakMode

* Implemented LineBreakMode on iOS

* Update Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

fixes xamarin#3106
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F100 in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕
Projects
.NET MAUI Backlog
  
Done
v4.3.0
  
In Progress
v4.6.0
  
In Progress
Milestone
No milestone
5 participants
@peterfoot @velocitysystems @samhouts @pictos @FIELDPOINT