GH-3106 Implemented LineBreakMode to Button #7810

pictos · 2019-10-04T02:09:35Z

Description of Change

Added the LineBreakMode to Button.

Issues Resolved

fixes [Enhancement] LineBreakMode for Button #3106

API Changes

Added:

LineBreakMode Button.LineBreakMode { get; set; } //Bindable Property

Platforms Affected

Core/XAML (all platforms)
iOS
Android
UWP

Behavioral/Visual Changes

Now users can set a line break mode to texts on Button, the default value doesn't affect any user.

None

Before/After Screenshots

PR Checklist

Targets the correct branch
Tests are passing (or failures are unrelated)

- Added LineBreakMode in ButtonRenderer

- Fixed button height update in Material iOS Button; - Code style fix on UWP

jsuarezruiz

@pictos Thanks for the PR.

Is the Android implementation missing? You could use https://github.com/xamarin/Xamarin.Forms/blob/9494ed5006040355edd41a5fa392fbc397f94d95/Xamarin.Forms.Platform.Android/Extensions/TextViewExtensions.cs

Could you add the property in Button Core Gallery https://github.com/xamarin/Xamarin.Forms/blob/9494ed5006040355edd41a5fa392fbc397f94d95/Xamarin.Forms.Controls/CoreGalleryPages/ButtonCoreGalleryPage.cs (and/or a sample Issue3106.cs?

jsuarezruiz · 2019-10-07T11:01:40Z

Xamarin.Forms.Platform.UAP/Extensions/TextBlockExtensions.cs

+{
+	internal static class TextBlockExtensions
+	{
+		public static void UpdateLineBreakMode(this TextBlock textBlock, LineBreakMode lineBreakMode)


Xamarin.Forms.Platform.iOS/Renderers/ButtonLayoutManager.cs

pictos · 2019-10-08T00:42:48Z

@jsuarezruiz I'll send the Android implementation later in this PR.

pictos · 2019-10-08T03:13:12Z

I realized that Label.LineBreakMode.CharacterWrap on Android doesn't work, can I add the fix in this PR?
#7118

jsuarezruiz · 2019-10-08T15:48:01Z

Mnn, better separate in another PR to facilitate traceability and history.

Xamarin.Forms.Platform.Android/ButtonLayoutManager.cs

samhouts · 2019-10-11T00:49:17Z

Xamarin.Forms.Platform.Android/Extensions/TextViewExtensions.cs

@@ -33,9 +33,9 @@ static void SetMaxLines(this TextView textView, Label label, int lines)
 			textView.SetMaxLines(lines);
 		}

-		public static void SetLineBreakMode(this TextView textView, Label label)
+		public static void SetLineBreakMode(this TextView textView, Label label, Button button = null)


ABI breaking change

@samhouts even with button being null by default is an API breaking change?

Well, it's technically not a breaking change yet, but an optional parameter here feels a bit strange. I think I'd rather see two methods here with some code duplication or some refactoring to call a third common method.

jsuarezruiz · 2019-10-30T17:03:47Z

@pictos Sure, let me check the code to see what may be happening. What platform does it happen (Android or iOS)?. Is it something that always happens?.

(This screenshot is using CharacterWrap).

pictos · 2019-10-31T02:03:18Z

@jsuarezruiz this occurs when you load the page, as you can see in the gif.

pictos · 2019-11-14T02:05:15Z

@jsuarezruiz any thoughts?

pictos · 2019-11-23T18:29:08Z

@jsuarezruiz any update on this?

Xamarin.Forms.Platform.UAP/ButtonRenderer.cs

Xamarin.Forms.Platform.UAP/Extensions/TextBlockExtensions.cs

Xamarin.Forms.Platform.UAP/LabelRenderer.cs

samhouts · 2020-01-10T00:47:00Z

Xamarin.Forms.Platform.Android/ButtonLayoutManager.cs

+				return;
+
+			view.SetLineBreakMode(_element);
+			view.SetAllCaps(true);


@samhouts, sorry I didn't understand

Are we supposed to be forcing AllCaps here? I didn't see this in the original version.

@samhouts, I'm sorry for the late reply... Well if we don't use that, the text in the button will not follow the actual behavior for text in the Android's button and text will not be all caps.

@pictos What causes it to not be all caps anymore?

@samhouts I don't know why that is, but I can try to find out (if it's needed). Just to exemplify, if I remove this line, the result is:

@pictos I think it's work investigating why that is different. Thanks!

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

titoleru · 2020-03-19T16:03:10Z

Ping - thanks a lot, this will be extremely helpful

pictos · 2020-06-20T23:49:18Z

I will close this one because it this very old, I created the #11147

pictos added 4 commits September 18, 2019 21:19

- Added Extention method to handle with LineBreakMode;

ad3d313

- Added LineBreakMode in ButtonRenderer

- Fixed performance issue

c373b0d

- Added LineBreakMode to iOS Button and Material iOS Button;

a375b2e

- Fixed button height update in Material iOS Button; - Code style fix on UWP

- Code fixes

e115b73

samhouts added Core p/iOS 🍎 p/UWP F100 t/enhancement ➕ labels Oct 4, 2019

samhouts added this to In Review in v4.4.0 Oct 4, 2019

samhouts requested review from jsuarezruiz and samhouts October 4, 2019 16:20

samhouts assigned jsuarezruiz and samhouts Oct 4, 2019

samhouts added the hacktoberfest 🍻 label Oct 4, 2019

jsuarezruiz suggested changes Oct 7, 2019

View reviewed changes

samhouts moved this from In Review to In Progress in v4.4.0 Oct 7, 2019

samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Oct 7, 2019

- Added Android implementation

0cd1150

- Back to original implementation of Label LineBreakMode

dcb95ff

samhouts added the p/Android label Oct 10, 2019

samhouts requested a review from jsuarezruiz October 11, 2019 00:47

samhouts suggested changes Oct 11, 2019

View reviewed changes

pictos added 3 commits October 12, 2019 17:57

code review

80e4129

Remove extention method from iOS

161fef0

- Revert code review

8b3765f

pictos marked this pull request as ready for review October 13, 2019 20:31

Merge branch 'master' into fix-3106

0fa86ec

samhouts added this to In Progress in v4.5.0 Nov 2, 2019

samhouts removed this from In Progress in v4.4.0 Nov 2, 2019

Merge branch 'master' into fix-3106

8175886

pictos mentioned this pull request Nov 23, 2019

[Enhancement] Button/Label Parity #1668

Closed

This comment has been minimized.

Sign in to view

samhouts suggested changes Jan 10, 2020

View reviewed changes

samhouts added this to In Progress in v4.6.0 Jan 10, 2020

pictos and others added 3 commits January 11, 2020 19:48

Update Xamarin.Forms.Platform.UAP/LabelRenderer.cs

4f1be35

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

Update Xamarin.Forms.Platform.UAP/ButtonRenderer.cs

8de7dfe

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

Update Xamarin.Forms.Platform.UAP/Extensions/TextBlockExtensions.cs

9da0ed4

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>

samhouts added the proposal-open label Feb 7, 2020

samhouts removed this from In Progress in v4.5.0 Feb 13, 2020

samhouts removed this from In Progress in v4.6.0 Mar 2, 2020

samhouts added this to In Progress in vCurrent (4.8.0) Mar 19, 2020

pictos mentioned this pull request Jun 17, 2020

Button text does not truncate #1812

Open

Merge branch 'master' into fix-3106

13d1cda

samhouts added p/iOS ?? and removed p/iOS ?? labels Jun 20, 2020

pictos mentioned this pull request Jun 20, 2020

GH-3106 Implemented LineBreakMode to Button #11147

Merged

2 tasks

pictos closed this Jun 20, 2020

vCurrent (4.8.0) automation moved this from In Progress to Closed Jun 20, 2020

pictos deleted the fix-3106 branch June 20, 2020 23:49

samhouts removed this from Closed in vCurrent (4.8.0) Jul 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-3106 Implemented LineBreakMode to Button #7810

GH-3106 Implemented LineBreakMode to Button #7810

pictos commented Oct 4, 2019

jsuarezruiz left a comment

jsuarezruiz Oct 7, 2019

pictos commented Oct 8, 2019

pictos commented Oct 8, 2019

jsuarezruiz commented Oct 8, 2019

samhouts Oct 11, 2019

pictos Oct 11, 2019

samhouts Oct 14, 2019

jsuarezruiz commented Oct 30, 2019

pictos commented Oct 31, 2019

pictos commented Nov 14, 2019

pictos commented Nov 23, 2019

This comment has been minimized.

samhouts Jan 10, 2020

pictos Jan 11, 2020

samhouts Jan 22, 2020

pictos Jan 26, 2020

samhouts Mar 19, 2020

pictos Mar 20, 2020

samhouts Mar 23, 2020

titoleru commented Mar 19, 2020

pictos commented Jun 20, 2020

GH-3106 Implemented LineBreakMode to Button #7810

GH-3106 Implemented LineBreakMode to Button #7810

Conversation

pictos commented Oct 4, 2019

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

PR Checklist

jsuarezruiz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pictos commented Oct 8, 2019

pictos commented Oct 8, 2019

jsuarezruiz commented Oct 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Oct 30, 2019

pictos commented Oct 31, 2019

pictos commented Nov 14, 2019

pictos commented Nov 23, 2019

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

titoleru commented Mar 19, 2020

pictos commented Jun 20, 2020