GH-3106 Implemented LineBreakMode to Button #11147

pictos · 2020-06-20T23:47:16Z

Description of Change

I created this one because the #7810 was very old and painful to do a rebase.

Added the LineBreakMode to Button.

Issues Resolved

fixes [Enhancement] LineBreakMode for Button #3106

API Changes

Added:

LineBreakMode Button.LineBreakMode { get; set; } //Bindable Property

Platforms Affected

Core/XAML (all platforms)
iOS
Android
UWP

Behavioral/Visual Changes

Now users can set a line break mode to texts on Button, the default value doesn't affect any user.

None

Before/After Screenshots

PR Checklist

Targets the correct branch
Tests are passing (or failures are unrelated)

pictos · 2020-06-20T23:50:51Z

Xamarin.Forms.Platform.Android/ButtonLayoutManager.cs

+				return;
+
+			view.SetLineBreakMode(_element);
+			_renderer.View.SetAllCaps(_element.TextTransform == TextTransform.Default);


@samhouts I used the same approach used here, to preserve the text as AllCaps.

Xamarin.Forms.Core/Button.cs

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

riverar · 2020-08-13T08:38:09Z

When resizing a UWP app window using MiddleTruncation or HeadTruncation, the entire string is truncated, either to the first character or first available space (see screenshot).

Test cases

<Button Text="HeadTruncationHeadTruncationHeadTruncationHeadTruncationHeadTruncation" LineBreakMode="HeadTruncation"/>
<Button Text="MiddleTruncationMiddleTruncationMiddleTruncationMiddleTruncationMiddleTruncation" LineBreakMode="MiddleTruncation"/>
<Button Text="TailTruncationTailTruncationTailTruncationTailTruncationTailTruncationTailTruncation" LineBreakMode="TailTruncation"/>

riverar

Changes look OK, but the above bug spoils the UWP experience. Thoughts on how to proceed here? @StephaneDelcroix @nickrandolph

I'm inclined to reject until the bug is resolved.

riverar · 2020-08-13T08:42:25Z

Xamarin.Forms.Platform.UAP/Extensions/TextBlockExtensions.cs

+					textBlock.TextWrapping = TextWrapping.Wrap;
+					break;
+				case LineBreakMode.HeadTruncation:
+					// TODO: This truncates at the end.


Nit: Remove TODO

@riverar, as you can see here those comments exist before my change, I just moved all the code around. I don't think this is a good idea to remove it.

.....and I think I may have added those myself 😅

riverar · 2020-08-13T08:42:32Z

Xamarin.Forms.Platform.UAP/Extensions/TextBlockExtensions.cs

+					DetermineTruncatedTextWrapping(textBlock);
+					break;
+				case LineBreakMode.MiddleTruncation:
+					// TODO: This truncates at the end.


Nit: Remove TODO

@riverar, as you can see here those comments exist before my change, I just moved all the code around. I don't think this is a good idea to remove it.

samhouts · 2020-08-13T22:19:52Z

Yep, I agree, that UWP bug seems a bit nasty. @pictos Wanna take a look at that?

pictos · 2020-08-13T23:16:38Z

@samhouts, this bug isn't related to this PR, you can see it here #5284 for UWP (we have some know-bugs for Android also). I can try to solve this bug (and others), but I think it would be better to address other PR for it. Does that make sense to you?

samhouts · 2020-08-13T23:36:51Z

@pictos Very good! Thanks for clarifying!

samhouts · 2020-08-17T20:52:47Z

@pictos It looks like this may have broken this test:

Are you able to run that locally?

samhouts · 2020-08-17T22:35:01Z

More information about the failing test: Android Fast Renderers only

System.Exception : Error while performing WaitForElement(Marked("Page1"), "Timed out waiting for element...", null, null, null)
----> System.TimeoutException : Timed out waiting for element...

riverar · 2020-08-21T08:36:19Z

Waiting for Microsoft resolution on this one.

pictos · 2020-08-21T22:15:02Z

@samhouts, if the test MemoryLeakB42329 is the only one that fails, can we assume that the failure is unrelated with this PR? (of course, if the test pass locally)

* Added LineBreakMode in the Button and TestAttributes * Added LineBreakMode implementation on Android platform * Added Issue into the Controls project * Removed unused method * Added UWP support for LineBreakMode * Implemented LineBreakMode on iOS * Update Xamarin.Forms.Core/Button.cs Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes #3106

* Added LineBreakMode in the Button and TestAttributes * Added LineBreakMode implementation on Android platform * Added Issue into the Controls project * Removed unused method * Added UWP support for LineBreakMode * Implemented LineBreakMode on iOS * Update Xamarin.Forms.Core/Button.cs Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#3106

* Added LineBreakMode in the Button and TestAttributes * Added LineBreakMode implementation on Android platform * Added Issue into the Controls project * Removed unused method * Added UWP support for LineBreakMode * Implemented LineBreakMode on iOS * Update Xamarin.Forms.Core/Button.cs Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes #3106

CartBlanche · 2020-12-18T20:40:34Z

I'm using 5.0.0.1791-pre5 and LineBreakMode on Buttons, does not appear to exist?

* Added LineBreakMode in the Button and TestAttributes * Added LineBreakMode implementation on Android platform * Added Issue into the Controls project * Removed unused method * Added UWP support for LineBreakMode * Implemented LineBreakMode on iOS * Update Xamarin.Forms.Core/Button.cs Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#3106

Juansero29 · 2021-02-28T21:44:46Z

Why is the API for LineBreakMode still not included in Xamarin.Forms 5.0.0.2012? When is this being included?

riverar · 2021-02-28T22:28:05Z

@samhouts Heads up ^

pictos · 2021-02-28T22:34:28Z

cc @Redth

* Added LineBreakMode in the Button and TestAttributes * Added LineBreakMode implementation on Android platform * Added Issue into the Controls project * Removed unused method * Added UWP support for LineBreakMode * Implemented LineBreakMode on iOS * Update Xamarin.Forms.Core/Button.cs Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Rui Marinho <me@ruimarinho.net> fixes xamarin#3106

toddanglin · 2021-12-31T20:13:22Z

@pictos @Redth @samhouts Bump. Can you add any insight in to the timing this enhancement will be available in Xamarin Forms? Still does not appear to be available as of 5.0.0.2291.

riverar · 2022-05-13T07:27:16Z

@samhouts Seems this change never made it out, are you tracking this?

pictos · 2022-05-13T14:10:31Z

cc: @jfversluis

jfversluis · 2022-05-17T17:41:25Z

Seems this was merged into main while we are releasing from 5.0.0 for a while. But this happened while I was not on the team so I can't give you the full context. Unfortunately, we don't really have a way for this to add this to Forms anymore as we're in maintanance mode and don't want to add any new APIs unless we really need to to support new platform OS features :(

.NET MAUI was branched of main which does have all the changed including this one. So I guess it's time to update to .NET MAUI!

pictos · 2022-05-17T17:43:32Z

Thanks for the reply

pictos added 6 commits June 17, 2020 22:27

Added LineBreakMode in the Button and TestAttributes

73da3d9

Added LineBreakMode implementation on Android platform

b3765eb

Added Issue into the Controls project

e77839a

Removed unused method

a0666a1

Added UWP support for LineBreakMode

4ab26a4

Implemented LineBreakMode on iOS

43d773d

pictos requested a review from StephaneDelcroix as a code owner June 20, 2020 23:47

pictos mentioned this pull request Jun 20, 2020

GH-3106 Implemented LineBreakMode to Button #7810

Closed

2 tasks

pictos commented Jun 20, 2020

View reviewed changes

samhouts added Core p/iOS 🍎 p/Android p/UWP F100 proposal-open t/enhancement ➕ labels Jun 21, 2020

samhouts requested a review from jsuarezruiz June 23, 2020 22:53

samhouts assigned jsuarezruiz and StephaneDelcroix Jun 23, 2020

StephaneDelcroix approved these changes Jun 24, 2020

View reviewed changes

Xamarin.Forms.Core/Button.cs Show resolved Hide resolved

Update Xamarin.Forms.Core/Button.cs

c9dcbf9

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

samhouts changed the base branch from master to main June 25, 2020 23:58

rmarinho and others added 2 commits July 1, 2020 11:06

Merge branch 'main' into xamaringh-3106

a360e39

Merge branch 'main' into xamaringh-3106

3cec083

samhouts added this to In Review in .NET MAUI Backlog Jul 30, 2020

riverar reviewed Aug 13, 2020

View reviewed changes

riverar approved these changes Aug 14, 2020

View reviewed changes

samhouts added API-change Heads-up to reviewers that this PR may contain an API change approved Has two approvals, no pending reviews, and no changes requested labels Aug 17, 2020

samhouts merged commit 17881ec into xamarin:main Sep 1, 2020

.NET MAUI Backlog automation moved this from In Review to Done Sep 1, 2020

pictos deleted the gh-3106 branch September 1, 2020 22:19

samhouts added this to Done in Sprint 175 Sep 2, 2020

rachelkang mentioned this pull request Nov 4, 2020

Address failing TextTransform tests on Android #12741

Merged

2 tasks

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-3106 Implemented LineBreakMode to Button #11147

GH-3106 Implemented LineBreakMode to Button #11147

pictos commented Jun 20, 2020 •

edited

pictos Jun 20, 2020

riverar commented Aug 13, 2020

riverar left a comment •

edited

riverar Aug 13, 2020

pictos Aug 13, 2020

samhouts Aug 13, 2020

riverar Aug 13, 2020

pictos Aug 13, 2020

samhouts commented Aug 13, 2020

pictos commented Aug 13, 2020 •

edited

samhouts commented Aug 13, 2020

samhouts commented Aug 17, 2020

samhouts commented Aug 17, 2020

riverar commented Aug 21, 2020

pictos commented Aug 21, 2020

CartBlanche commented Dec 18, 2020

Juansero29 commented Feb 28, 2021

riverar commented Feb 28, 2021

pictos commented Feb 28, 2021

toddanglin commented Dec 31, 2021

This comment was marked as off-topic.

riverar commented May 13, 2022

pictos commented May 13, 2022

jfversluis commented May 17, 2022 •

edited

pictos commented May 17, 2022

GH-3106 Implemented LineBreakMode to Button #11147

GH-3106 Implemented LineBreakMode to Button #11147

Conversation

pictos commented Jun 20, 2020 • edited

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

PR Checklist

pictos Jun 20, 2020

Choose a reason for hiding this comment

riverar commented Aug 13, 2020

riverar left a comment • edited

Choose a reason for hiding this comment

riverar Aug 13, 2020

Choose a reason for hiding this comment

pictos Aug 13, 2020

Choose a reason for hiding this comment

samhouts Aug 13, 2020

Choose a reason for hiding this comment

riverar Aug 13, 2020

Choose a reason for hiding this comment

pictos Aug 13, 2020

Choose a reason for hiding this comment

samhouts commented Aug 13, 2020

pictos commented Aug 13, 2020 • edited

samhouts commented Aug 13, 2020

samhouts commented Aug 17, 2020

samhouts commented Aug 17, 2020

riverar commented Aug 21, 2020

pictos commented Aug 21, 2020

CartBlanche commented Dec 18, 2020

Juansero29 commented Feb 28, 2021

riverar commented Feb 28, 2021

pictos commented Feb 28, 2021

toddanglin commented Dec 31, 2021

This comment was marked as off-topic.

riverar commented May 13, 2022

pictos commented May 13, 2022

jfversluis commented May 17, 2022 • edited

pictos commented May 17, 2022

pictos commented Jun 20, 2020 •

edited

riverar left a comment •

edited

pictos commented Aug 13, 2020 •

edited

jfversluis commented May 17, 2022 •

edited