Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

ListView Selection Color disappeared on ios 13 #7850

Closed
OmerHmead opened this issue Oct 7, 2019 · 6 comments
Closed

ListView Selection Color disappeared on ios 13 #7850

OmerHmead opened this issue Oct 7, 2019 · 6 comments
Labels
a/listview Problems with the ListView/TableView e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! iOS 13 t/bug 🐛

Comments

@OmerHmead
Copy link

OmerHmead commented Oct 7, 2019

Description

Steps to Reproduce

  1. Download the sample project for List View →https://docs.microsoft.com/en-us/samples/xamarin/xamarin-forms-samples/workingwithlistview/
  2. Update Xamarin forms to 4.2.0.848062
  3. Run the sample to any device with ios 13

Expected Behavior

when you tab to the cell view the selection color should be appeared

Actual Behavior

the tab event invoked but the selection color not appeared

Basic Information

  • Version with issue: Xamarin 4.2.0.848062
  • Last known good version: Xamarin 3.4.0.1008975
  • IDE: Visual Studio 2019
  • Platform Target Frameworks:
    • iOS:
  • Affected Devices:
    iphone 11 pro max 13.0 and ipad pro 12.9 inch 3rd generation 13.0

Screenshots

2019-10-07_12-11-58

@OmerHmead OmerHmead added s/unverified New report that has yet to be verified t/bug 🐛 labels Oct 7, 2019
@jfversluis
Copy link
Member

jfversluis commented Oct 7, 2019

Thank you for reporting @OmerHmead

I have a suspicion this has something to do with the changes for dark mode.

When I change the code from the project you linked to something like:

<ListView x:Name="listView" ItemTapped="OnItemTapped" ItemsSource="{Binding .}" BackgroundColor="Transparent">
        <ListView.ItemTemplate>
            <DataTemplate>
                <ViewCell>
                    <Label Text="{Binding .}" BackgroundColor="Transparent" />
                </ViewCell>
            </DataTemplate>
        </ListView.ItemTemplate>
    </ListView>

(note the BackgroundColor tags)

Then I start seeing the highlighting again. Also, running this exact same code on iOS 12, it works.

Attached is a more standalone and up-to-date XF project:
Repro7850.zip

Possibly related: #7683 #7304

@jfversluis jfversluis added a/listview Problems with the ListView/TableView iOS 13 e/3 🕒 3 and removed s/unverified New report that has yet to be verified labels Oct 7, 2019
@Welchen
Copy link

Welchen commented Oct 7, 2019

I am having this same issue. Started with iOS 13. Have posted on the Forums and haven't seen a fix but have also had others report the same.

@deczaloth
Copy link

deczaloth commented Oct 8, 2019

@jfversluis Great! Thanks for the workaround!

Also, I have two builds of the same app: one made before the release of iOS 13, and the other made after the release. If i run both releases on an iOS 13 device, in the first the listview behaves correctly, but in the second behaves as described in the original post.
I suppose the issue has something to do with the mono update rather than with the iOS version itself.
@jfversluis , could you confirm this?

@jfversluis
Copy link
Member

So, just to check if I understand correctly. You have the same app, once built before iOS 13 and one built after the release of iOS 13.

If you run the pre-iOS13 one on iOS 13 it still works correctly?

I don't think it has to do with the Mono version, but probably that you are building against the new iOS 13 APIs. The other thing that probably got updated between these two versions is Xcode?

@deczaloth
Copy link

deczaloth commented Oct 8, 2019

So, just to check if I understand correctly. You have the same app, once built before iOS 13 and one built after the release of iOS 13.

If you run the pre-iOS13 one on iOS 13 it still works correctly?

Yep, thats right.
This i know since i have different builds in my TestFlight App running in a device with iOS 13.

@jfversluis
Copy link
Member

Gotcha! Valuable information, thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/listview Problems with the ListView/TableView e/3 🕒 3 in-progress This issue has an associated pull request that may resolve it! iOS 13 t/bug 🐛
Projects
None yet
Development

No branches or pull requests

5 participants