Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Image animation not working in GTK #8732

Closed
ysangkok opened this issue Dec 3, 2019 · 29 comments · Fixed by #9649
Closed

[Bug] Image animation not working in GTK #8732

ysangkok opened this issue Dec 3, 2019 · 29 comments · Fixed by #9649
Labels
a/image in-progress This issue has an associated pull request that may resolve it! p/gtk t/bug 🐛

Comments

@ysangkok
Copy link

ysangkok commented Dec 3, 2019

Description

It seems like image animation is not working in GTK. Similar code worked on the UWP backend.

Steps to Reproduce

https://github.com/ysangkok/XamarinGTKAnimationIssue

src.zip

Expected Behavior

Image should be animated.

Actual Behavior

Image is not animated.

Basic Information

  • Version with issue: 4.4.0.991210-pre2
  • Last known good version: don't know
  • Platform Target Frameworks: Ubuntu 18.04 with gtk-sharp 2.12.45-0xamarin17+ubuntu1804
  • Nuget Packages: See linked repository
@ysangkok ysangkok added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 3, 2019
@PureWeen PureWeen added the p/gtk label Dec 7, 2019
@PureWeen PureWeen added p/gtk and removed s/unverified New report that has yet to be verified labels Dec 7, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.045 ETH (150.03 USD @ $143.57/ETH) attached to it.

@gitcoinbot
Copy link

@izoch Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@miloszeka
Copy link

Commenting back

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@izoch due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul53
Copy link

mul53 commented Feb 11, 2020

@samhouts does this require work? Would like to work on it

@knocte
Copy link
Contributor

knocte commented Feb 15, 2020

@mul53 what do you mean?

@mul53
Copy link

mul53 commented Feb 15, 2020

@knocte working on the bug

@gitcoinbot
Copy link

gitcoinbot commented Feb 18, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 week ago.
Please review their action plans below:

1) bobface has been approved to start work.

I can fix the bug with the animation.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.045 ETH (272.64 USD @ $260.9/ETH) has been submitted by:

  1. @bobface

@knocte please take a look at the submitted work:


@ysangkok
Copy link
Author

I tested this, with the sample project from the issue. It works, but it consumes 100% CPU and is not smooth. I am not sure whether this is a problem with this PR or with the sample project (which I made).

@Bobface
Copy link
Contributor

Bobface commented Feb 24, 2020

Hmm, would it be possible to link the image you have used?

@Bobface
Copy link
Contributor

Bobface commented Feb 24, 2020

@ysangkok Also, the large the image the more expensive the calculation for scale & rotate. Did you test if it works smoothly with a small image, say 50x50?

@ysangkok
Copy link
Author

@Bobface I have a HiDPI monitor, so 50x50 is really small. But you are right that smaller sizes have less CPU load. For example, a 250x188 image runs with only 50% CPU utilization. I am using the ImageMagick logo image. To generate it in its full size (with width 500px), use convert logo: logo.png.

@knocte
Copy link
Contributor

knocte commented Feb 25, 2020

@Bobface
Copy link
Contributor

Bobface commented Feb 25, 2020

@ysangkok Okay, so the size of the image is definitely the problem.
@knocte Thanks, but it seems like I already do everything as described in that thread.

@knocte
Copy link
Contributor

knocte commented Feb 25, 2020

Even the FPS reduction?

@Bobface
Copy link
Contributor

Bobface commented Feb 25, 2020

That should be achievable by reducing the frequency rate of the animation in @ysangkok 's repro (dummyFrequencyRate in LoadingPage.xaml.fs). However he links to another issue which says that that parameter is also not implemented in Xamarin.Forms and has no effect. Is that still correct @ysangkok ?

@ysangkok
Copy link
Author

@Bobface I have tested your PR 9856 with this one cherry-picked on top. Everything works as expected. Thank you.

@knocte
Copy link
Contributor

knocte commented Mar 12, 2020

@ysangkok you mean CPU doesn't go to 100% anymore?

@ysangkok
Copy link
Author

ysangkok commented Mar 12, 2020

@knocte CPU consumption is not too high with reasonable animation update intervals and smaller image sizes, no.

@Solexplorer
Copy link

Hi @ysangkok,

Is the fix provided by @Bobface working?

@ysangkok
Copy link
Author

ysangkok commented Apr 6, 2020

@Solexplorer yes

@Solexplorer
Copy link

@knocte Does this bounty also need review from maintainers?

@knocte
Copy link
Contributor

knocte commented Apr 6, 2020

Yes but this should be merged only after PR 9856 is merged.

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Apr 30, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.045 ETH (249.23 USD @ $238.5/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) bobface has started work.

.................................................................

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

⚡️ A tip worth 1.04000 ETH (248.04 USD @ $238.5/ETH) has been granted to @Bobface for this issue from @knocte. ⚡️

Nice work @Bobface! Your tip has automatically been deposited in the ETH address we have on file.

@knocte
Copy link
Contributor

knocte commented Jul 20, 2020

Fixed by #9649 which was merged , @ysangkok you can close

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This Bounty has been completed.

Additional Tips for this Bounty:

  • knocte tipped 1.0400 ETH worth 248.04 USD to bobface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/image in-progress This issue has an associated pull request that may resolve it! p/gtk t/bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants