Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell Flyout - Weird line at the bottom of the items in iOS #8881

Closed
HobDev opened this issue Dec 13, 2019 · 3 comments · Fixed by #9429
Closed

[Bug] Shell Flyout - Weird line at the bottom of the items in iOS #8881

HobDev opened this issue Dec 13, 2019 · 3 comments · Fixed by #9429
Labels
a/shell 🐚 e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
vNext+1 (5.0.0)
Milestone
5.0.0

Comments

@HobDev
Copy link

HobDev commented Dec 13, 2019

Description

There is an unwanted line below the MenuItems or FlyoutItems in Shell.

Steps to Reproduce

  1. Run the repro project with MenuItems and flyoutItems one by one.

Basic Information

  • Version with issue:4.4.0.991265
  • IDE:VSMac
  • Affected Devices:iOS

Reproduction Link

FlyoutBug.zip
@HobDev HobDev added s/unverified New report that has yet to be verified t/bug 🐛 labels Dec 13, 2019
@pauldipietro pauldipietro added this to New in Triage Dec 13, 2019
@HobDev HobDev mentioned this issue Dec 13, 2019
Closed
@kingces95
Copy link
Contributor

Could you please attach screenshot with an annotation of the unwanted line?

@kingces95 kingces95 moved this from New to Needs Info in Triage Dec 13, 2019
@HobDev
Copy link
Author

HobDev commented Dec 14, 2019

The arrow is pointing towards unwanted line

Simulator Screen Shot - iPhone 11 - 2019-12-14 at 20 11 42

@samhouts samhouts moved this from Needs Info to New in Triage Dec 15, 2019
@rmarinho rmarinho added a/shell 🐚 and removed s/unverified New report that has yet to be verified labels Dec 16, 2019
@rmarinho rmarinho moved this from New to Needs Estimate in Triage Dec 16, 2019
@samhouts samhouts added the e/3 🕒 3 label Jan 2, 2020
@samhouts samhouts moved this from Needs Estimate to Ready For Work in Triage Jan 2, 2020
@samhouts samhouts added this to To do in iOS Ready For Work Jan 3, 2020
@samhouts samhouts removed this from Ready For Work in Triage Jan 3, 2020
@samhouts samhouts added this to Backlog in Shell Jan 3, 2020
@pictos pictos mentioned this issue Feb 5, 2020
Merged
2 tasks
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Feb 7, 2020
@samhouts samhouts added this to In Progress in v4.6.0 Feb 7, 2020
@samhouts samhouts moved this from Backlog to In Progress in Shell Feb 19, 2020
@samhouts samhouts moved this from To do to In progress in iOS Ready For Work May 6, 2020
@samhouts samhouts removed this from In Progress in v4.6.0 Jun 8, 2020
@samhouts samhouts added this to In Progress in 4.7.0 Jun 20, 2020
@samhouts samhouts removed this from In Progress in 4.7.0 Jul 4, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested labels Jul 17, 2020
@samhouts samhouts added up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Jul 17, 2020
@samhouts samhouts added this to In Progress in vCurrent (4.8.0) Jul 30, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested labels Jul 31, 2020
@samhouts samhouts removed this from In Progress in vCurrent (4.8.0) Aug 4, 2020
@samhouts samhouts added this to In Progress in vNext+1 (5.0.0) Aug 11, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
PureWeen pushed a commit that referenced this issue Aug 28, 2020
@pictos @samhouts
GH-8881 - Remove the line at the flyout's end (#9429)
3df3631 
* Prevent the line appears

* Added to control gallery

* code style fix

* Fixed the IncrementGroup logic;
revert ShellTableViewSource implementation

* Added unit tests.

* removed Issue8881

* code review for unit tests

Co-authored-by: Pedro Jesus <pedro.pj.souza@hotmail.com>
Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com>
@samhouts samhouts moved this from In Progress to Done in vNext+1 (5.0.0) Aug 28, 2020
@samhouts
Copy link
Member

closed by #9429

iOS Ready For Work automation moved this from In progress to Done Sep 14, 2020
Shell automation moved this from In Progress to Done Sep 14, 2020
@samhouts samhouts removed this from Done in iOS Ready For Work Nov 3, 2020
@samhouts samhouts removed this from Done in Shell Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a/shell 🐚 e/3 🕒 3 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! p/iOS 🍎 t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

GH-8881 - Remove the line at the flyout's end pictos/Xamarin.Forms
4 participants
@rmarinho @kingces95 @samhouts @HobDev