Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

GH-8881 - Remove the line at the flyout's end #9429

Merged
merged 11 commits into from
Aug 28, 2020
Merged

GH-8881 - Remove the line at the flyout's end #9429

merged 11 commits into from
Aug 28, 2020

Conversation

pictos
Copy link
Contributor

@pictos pictos commented Feb 5, 2020 •
edited by PureWeen
Loading

Description of Change

Remove the line at the end of Flyout in Shell.

Issues Resolved

Platforms Affected

  • iOS

Before/After Screenshots

Before:
image

After:
image

Testing Procedure

Open the Issue8881, in the Control Gallery, and open the Flyout. If you don't see the line at the end of Flyout we are good.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@pictos pictos requested a review from PureWeen February 5, 2020 02:41
@pictos pictos mentioned this pull request Feb 26, 2020
Merged
2 tasks
@samhouts samhouts changed the base branch from master to 4.6.0 February 27, 2020 23:30
@samhouts samhouts self-requested a review May 28, 2020 01:15
@samhouts samhouts self-assigned this May 28, 2020
@samhouts samhouts changed the base branch from 4.6.0 to 4.7.0 June 8, 2020 21:50
@PureWeen PureWeen changed the base branch from 4.7.0 to 4.8.0 July 4, 2020 03:45
@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 4, 2020 22:16
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 15, 2020
@pictos
Fixed the IncrementGroup logic;
f8feb22 
revert ShellTableViewSource implementation
@pictos pictos requested a review from PureWeen August 20, 2020 00:45
@PureWeen PureWeen requested a review from samhouts August 26, 2020 02:21
@PureWeen PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 26, 2020
@PureWeen PureWeen removed the request for review from StephaneDelcroix August 26, 2020 02:47
PureWeen
PureWeen suggested changes Aug 27, 2020
View reviewed changes
Xamarin.Forms.Core.UnitTests/ShellTests.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Core.UnitTests/ShellTests.cs Outdated Show resolved Hide resolved
@PureWeen PureWeen merged commit 3df3631 into xamarin:5.0.0 Aug 28, 2020
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Aug 31, 2020
@samhouts samhouts mentioned this pull request Sep 14, 2020
Closed
@pictos pictos deleted the fix-8881 branch July 22, 2021 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@PureWeen PureWeen

@samhouts samhouts

Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested Core p/iOS 🍎 p/Tizen t/bug 🐛
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Shell Flyout - Weird line at the bottom of the items in iOS
3 participants
@pictos @PureWeen @samhouts