Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Apply maximum starred column/row size for all starred columns/rows #13085

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Apply maximum starred column/row size for all starred columns/rows #13085

merged 1 commit into from
Dec 14, 2020

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Dec 9, 2020 •
edited

Description of Change

Fixes regressions in the calculation of starred row/columns sizes introduced in 4.8. Column/row size values for starred columns/rows were being applied proportionally across requested space of the columns/rows, rather than taking into account the size of the largest column/row. This resulted in larger columns/rows being "squashed" and grid cells with StackLayouts overlapping other grid cells.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Automated unit tests

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@hartez hartez added a/grid a/layout blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. i/regression in-progress This issue has an associated pull request that may resolve it! labels Dec 9, 2020
@samhouts samhouts added Core 4.8.0 regression on 4.8.0 t/bug 🐛 5.0.0 Regression on 5.0.0 labels Dec 10, 2020
@hartez hartez changed the base branch from 5.0.0 to 4.8.0 December 11, 2020 01:30
@hartez
Copy link
Contributor Author

hartez commented Dec 11, 2020

UITest failures are unrelated.

@PureWeen PureWeen mentioned this pull request Dec 11, 2020
Open
@rmarinho rmarinho added this to To do in vCurrent (4.8.0) via automation Dec 14, 2020
@rmarinho rmarinho added this to To do in vNext+1 (5.0.0) via automation Dec 14, 2020
@rmarinho rmarinho moved this from To do to In Review in vCurrent (4.8.0) Dec 14, 2020
@rmarinho rmarinho moved this from To do to In Review in vNext+1 (5.0.0) Dec 14, 2020
@rmarinho rmarinho merged commit 30f29a3 into 4.8.0 Dec 14, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Dec 14, 2020
vNext+1 (5.0.0) automation moved this from In Review to Done Dec 14, 2020
@rmarinho rmarinho deleted the fix-12961 branch December 14, 2020 22:43
@hartez hartez mentioned this pull request Dec 15, 2020
Merged
2 tasks
@samhouts samhouts added this to the 4.8.0 milestone Dec 18, 2020
@samhouts samhouts added this to the 4.8.0 milestone Dec 18, 2020
@hartez hartez mentioned this pull request Dec 18, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
4.8.0 regression on 4.8.0 5.0.0 Regression on 5.0.0 a/grid a/layout blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. Core i/regression in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
No open projects
vCurrent (4.8.0)
  
Done
vNext+1 (5.0.0)
Done
Milestone
4.8.0
4 participants
@hartez @rmarinho @PureWeen @samhouts