Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Grid height is not correctly computed on 4.8.0.1687 #12900

Closed
usausa opened this issue Nov 19, 2020 · 4 comments
Closed

[Bug] Grid height is not correctly computed on 4.8.0.1687 #12900

usausa opened this issue Nov 19, 2020 · 4 comments
Assignees
Labels
a/layout i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Milestone

Comments

@usausa
Copy link

usausa commented Nov 19, 2020

Description

I have a layout with grids and labels.
When I updated to the new version of Xamarin.Forms(4.8.0.1687), the layout is now broken.
Also, in the new version the layout varies depending on the value of the label.

Steps to Reproduce

  1. See xaml below
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             x:Class="LayoutSample.MainPage">

    <Grid HorizontalOptions="FillAndExpand" VerticalOptions="FillAndExpand">

        <Grid.RowDefinitions>
            <RowDefinition Height="Auto" />
            <RowDefinition Height="*" />
        </Grid.RowDefinitions>

        <Grid Grid.Row="0"
              Background="Red">
            <Grid.ColumnDefinitions>
                <ColumnDefinition Width="Auto" />
                <ColumnDefinition Width="*" />
                <ColumnDefinition Width="Auto" />
                <ColumnDefinition Width="2*" />
            </Grid.ColumnDefinitions>

            <Label Grid.Column="0"
                   Text="Type"
                   FontSize="Large"
                   HorizontalOptions="Start"
                   VerticalOptions="Center" />
            <Label Grid.Column="1"
                   Text="123"
                   Background="White"
                   FontSize="Large"
                   VerticalOptions="Center" />
            <Label Grid.Column="2"
                   Text="No"
                   FontSize="Large"
                   HorizontalOptions="Start"
                   VerticalOptions="Center" />
            <Label Grid.Column="3"
                   Text="999-999"
                   Background="White"
                   FontSize="Large"
                   VerticalOptions="Center" />
        </Grid>

        <BoxView Grid.Row="1"
                 Background="Blue" />

    </Grid>

</ContentPage>

Expected Behavior

See a screenshot of 4.8.0.1560.

Actual Behavior

See a screenshot of 4.8.0.1687.

Basic Information

Version with issue: 4.8.0.1687
Last known good version: 4.8.0.1560
Platform : Android

Screenshots

  • 4.8.0.1560

4.8.0.1560

  • 4.8.0.1687

4.8.0.1687

  • 4.8.0.1687 (Label.Text is empty)

4.8.0.1687b

@usausa usausa added s/unverified New report that has yet to be verified t/bug 🐛 labels Nov 19, 2020
@samhouts samhouts added this to New in Triage Nov 19, 2020
@jsuarezruiz jsuarezruiz added a/layout i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often and removed s/unverified New report that has yet to be verified labels Nov 19, 2020
@jsuarezruiz jsuarezruiz moved this from New to Needs Estimate in Triage Nov 19, 2020
@jsuarezruiz
Copy link
Contributor

Attached repro sample: Issue12900.zip

@Transis-Felipe
Copy link
Contributor

Same issue for me

@MagicAndre1981
Copy link
Contributor

I also see this in Android and UWP

@nZeus
Copy link

nZeus commented Dec 7, 2020

Hi. We cannot upgrade Xamarin.Forms from 4.6.0.726 to 4.8.0.1687 because we also have the same issue. Height="70*" doesn't work anymore.
4.6.0.726:

4.8.0.1687:

MagicAndre1981 referenced this issue Dec 7, 2020
* Fix vertical column measurement when star column coefficient is < 1
Fixes #12292; Fixes #12363

* Fix vertical text layout issues with StackLayouts in Grids
Fixes #12462, Fixes #12175, Fixes #12001
@hartez hartez added the in-progress This issue has an associated pull request that may resolve it! label Dec 13, 2020
@hartez hartez added this to To do in Other Ready For Work via automation Dec 13, 2020
@hartez hartez removed this from Needs Estimate in Triage Dec 13, 2020
@hartez hartez moved this from To do to In progress in Other Ready For Work Dec 13, 2020
@hartez hartez added this to the 4.8.0 milestone Dec 13, 2020
@hartez hartez closed this as completed in 30f29a3 Dec 17, 2020
Other Ready For Work automation moved this from In progress to Done Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/layout i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often in-progress This issue has an associated pull request that may resolve it! t/bug 🐛
Projects
Development

No branches or pull requests

6 participants