This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Shell,Android] Allow transparent background on Shell Header #13322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas how to UITest this @PureWeen ? |
jsuarezruiz
approved these changes
Jan 14, 2021
rmarinho
changed the title
PureWeen
approved these changes
Jan 14, 2021
PureWeen
reviewed
Jan 14, 2021
| } | ||
|
|
||
| protected virtual void LayoutView(double x, double y, double width, double height) | ||
| { | ||
| View?.Layout(new Rectangle(x, y, width, height)); | ||
| _shellViewRenderer.LayoutView(width, height); |
There was a problem hiding this comment.
All this change does is makes sure that UpdateElevation is called when the header is created. This allows the user to set the flyout header elevation via the platform specific
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow transparent Shell Header.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Header should be transparent and not white by default
Before/After Screenshots
Before
After
Not applicable
Testing Procedure
PR Checklist