Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell Flyout - Flyout Header adds bottom outline #12309

Closed
rlubkowski opened this issue Sep 30, 2020 · 1 comment · Fixed by #13322
Closed

[Bug] Shell Flyout - Flyout Header adds bottom outline #12309

rlubkowski opened this issue Sep 30, 2020 · 1 comment · Fixed by #13322

Comments

@rlubkowski
Copy link

rlubkowski commented Sep 30, 2020

Description

Defining FlyoutHeader or FlyoutHeaderTemplate adds a bottom shadow/outline that shouldn't be there.

Basic Information

  • Version with issue: 4.8.0.1451
  • IDE: Visual Studio Community 2019 (16.7.5)
  • Android: 9.0 (Pie)

Screenshots

Screenshot (1)
Screenshot (2)
Screenshot (3)

Reproduction Link

FlyoutHeaderShadow.zip

Workaround

Workaround for this issue is to create custom shell renderer:

public class CustomShellRenderer : ShellRenderer
{
    public CustomShellRenderer(Context context) 
        : base(context) {}

    protected override IShellFlyoutContentRenderer CreateShellFlyoutContentRenderer()
    {
        var flyoutContent = base.CreateShellFlyoutContentRenderer();

        var cl = ((CoordinatorLayout)flyoutContent.AndroidView);

        for (int index = 0; index < cl.ChildCount; index++)
        {
            var child = cl.GetChildAt(index);

            if (child is AppBarLayout)
            {
                var view = (AppBarLayout)child;
                view.OutlineProvider = null;
            }
        }
        return flyoutContent;
    }
}
@rlubkowski rlubkowski added s/unverified New report that has yet to be verified t/bug 🐛 labels Sep 30, 2020
@rlubkowski rlubkowski changed the title [Bug] Shell Flyout - Flyout Header adds bottom shadow [Bug] Shell Flyout - Flyout Header adds bottom outline Sep 30, 2020
@hartez hartez added p/Android a/shell 🐚 e/5 🕔 5 and removed s/unverified New report that has yet to be verified labels Sep 30, 2020
@gechurekimoiMedbook
Copy link

wow thanks for this walk around , it helped sort my design

rmarinho added a commit that referenced this issue Jan 15, 2021
…ixes #13305  fixes #12309

* Fix layout of FlyoutContent

* - fix ui tests

* [Controls] Add repo for issue #13305

* [Controls] Add more content to FlyoutBackground test

* [Android]  Make Shell header transparent

* - fix header container to set elevation

Co-authored-by: shane <shneuvil@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants