[macOS] Fix RadioButton activated behaviour

[JunielKatarn]

Description of Change

Allows RadioButton in macOS to respond to the Activated event, thus propagating the necessary property changes.

Issues Resolved

• closes [Bug] [Xamarin.Mac] RadioButton in detail page of master detail page : IsChecked not binding on launch, Multiple selection #13984

API Changes

None

Platforms Affected

• macOS

Behavioral/Visual Changes

Radio buttons within a group get exclusively activated, as intended.

Before/After Screenshots

Before:

After:

Testing Procedure

1. Add a group of RadioButton elements.
2. Click on each one of them, verifying only one is active at a time.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[mhrastegari]

Wow nice job we really needed this! ❤ i hope this will be merged soon.

[JunielKatarn]

Hi @jsuarezruiz. This change is rather small and solves clear usability issues. Any chance the Xamarin team could take a look?
(BTW, I am actively working on the GTK platform and will be sending fixes shortly :) )

[mhrastegari]

i've used your renderer and works nicely but
it seems that doesn't work with xamarin essentials preferences,
because every time i switch to the settings page my radio button group is unchecked!

[JunielKatarn]

i've used your renderer and works nicely but
it seems that doesn't work with xamarin essentials preferences,
because every time i switch to the settings page my radio button group is unchecked!

Hi. Thanks for letting me know.
Do you have a concrete reproducible test case? I may be able to look into it.

[mhrastegari]

yeah sure!
macOSRadioButton.zip

[chucker]

every time i switch to the settings page my radio button group is unchecked

Try this slight adjustment:

protected override void OnElementChanged(ElementChangedEventArgs<RadioButton> e)
{
	base.OnElementChanged(e);
			
	if (Control != null)
	{
		Control.Activated += HandleActivated;

		if (e.NewElement.IsChecked)
			Control.State = NSCellStateValue.On;
	}
}

[mhrastegari]

Thanks @chucker it worked!!! It's fully working now.

[mhrastegari]

@JunielKatarn could you add this to your PR?

[chucker]

(To expand on this a little: I've found that to help when a radio button is supposed to be initially checked, before the renderer comes into play. In that case, the renderer never receives the appropriate property changed event.

However, I'm not sure this fixes all issues. I'm also simultaneously running into #13752, which isn't macOS-specific. It might also be that, once #13752 is fixed, my above adjustment isn't actually necessary.)

[JunielKatarn]

@JunielKatarn could you add this to your PR?

Right away! :)

Thanks for the contribution, @chucker.

[JunielKatarn]

@jsuarezruiz The fix for initial state (i.e. when loading from Xamarin Essentials settings) has been applied.

Is there any pending requirement for this change to be merged?

[mhrastegari]

Shouldn't this have been merged by now? @rmarinho