[Bug] Java.Lang.IndexOutOfBoundsException: setSpan

[Transis-Felipe]

Description

IndexOutOfBoundsException observed in Xamarin.Android/Xamarin.Forms code in the wild.

Stack trace:

JniEnvironment+InstanceMethods.CallNonvirtualVoidMethod (Java.Interop.JniObjectReference instance, Java.Interop.JniObjectReference type, Java.Interop.JniMethodInfo method, Java.Interop.JniArgumentValue* args)
JniPeerMembers+JniInstanceMethods.InvokeVirtualVoidMethod (System.String encodedMember, Java.Interop.IJavaPeerable self, Java.Interop.JniArgumentValue* parameters)
EditText.SetSelection (System.Int32 index)
EntryRendererBase`1[TControl].UpdateText ()
EntryRendererBase`1[TControl].OnElementPropertyChanged (System.Object sender, System.ComponentModel.PropertyChangedEventArgs e)
(wrapper delegate-invoke) <Module>.invoke_void_object_PropertyChangedEventArgs(object,System.ComponentModel.PropertyChangedEventArgs)
BindableObject.OnPropertyChanged (System.String propertyName)
Element.OnPropertyChanged (System.String propertyName)
BindableObject.SetValueActual (Xamarin.Forms.BindableProperty property, Xamarin.Forms.BindableObject+BindablePropertyContext context, System.Object value, System.Boolean currentlyApplying, Xamarin.Forms.Internals.SetValueFlags attributes, System.Boolean silent)
BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes, Xamarin.Forms.BindableObject+SetValuePrivateFlags privateAttributes)
BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes)
Element.SetValueFromRenderer (Xamarin.Forms.BindableProperty property, System.Object value)
TextTransformUtilites.SetPlainText (Xamarin.Forms.InputView inputView, System.String nativeText)
ITextWatcher.OnTextChanged (Java.Lang.ICharSequence s, System.Int32 start, System.Int32 before, System.Int32 count)
ITextWatcherInvoker.n_OnTextChanged_Ljava_lang_CharSequence_III (System.IntPtr jnienv, System.IntPtr native__this, System.IntPtr native_s, System.Int32 start, System.Int32 before, System.Int32 count)
(wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.74(intptr,intptr,intptr,int,int,int)
java.lang.IndexOutOfBoundsException: setSpan (16 ... 16) ends beyond length 15
android.text.SpannableStringBuilder.checkRange SpannableStringBuilder.java:1331
android.text.SpannableStringBuilder.setSpan SpannableStringBuilder.java:690
android.text.SpannableStringBuilder.setSpan SpannableStringBuilder.java:682
android.text.Selection.setSelection Selection.java:94
android.text.Selection.setSelection Selection.java:78
android.text.Selection.setSelection Selection.java:153
android.widget.EditText.setSelection EditText.java:136
crc643f46942d9dd1fff9.EntryRendererBase_1.n_onTextChanged(Native Method)
crc643f46942d9dd1fff9.EntryRendererBase_1.onTextChanged(Unknown Source:0)
android.widget.TextView.sendOnTextChanged TextView.java:10587
android.widget.TextView.handleTextChanged TextView.java:10677
android.widget.TextView$ChangeWatcher.onTextChanged TextView.java:13464
android.text.SpannableStringBuilder.sendTextChanged SpannableStringBuilder.java:1273
android.text.SpannableStringBuilder.replace SpannableStringBuilder.java:576
android.text.SpannableStringBuilder.replace SpannableStringBuilder.java:507
android.text.SpannableStringBuilder.replace SpannableStringBuilder.java:37
android.text.method.NumberKeyListener.onKeyDown NumberKeyListener.java:131
android.widget.TextView.doKeyDown TextView.java:8470
android.widget.TextView.onKeyDown TextView.java:8227
android.view.KeyEvent.dispatch KeyEvent.java:2801
android.view.View.dispatchKeyEvent View.java:13403
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
androidx.core.widget.NestedScrollView.dispatchKeyEvent(Unknown Source:0)
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
android.view.ViewGroup.dispatchKeyEvent ViewGroup.java:1922
com.android.internal.policy.DecorView.superDispatchKeyEvent DecorView.java:473
com.android.internal.policy.PhoneWindow.superDispatchKeyEvent PhoneWindow.java:1869
android.app.Activity.dispatchKeyEvent Activity.java:3964
androidx.core.app.ComponentActivity.superDispatchKeyEvent(Unknown Source:0)
androidx.core.view.KeyEventDispatcher.dispatchKeyEvent(Unknown Source:10)
androidx.core.app.ComponentActivity.dispatchKeyEvent(Unknown Source:18)
androidx.appcompat.app.AppCompatActivity.dispatchKeyEvent(Unknown Source:22)
androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(Unknown Source:2)
androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.dispatchKeyEvent(Unknown Source:8)
androidx.appcompat.view.WindowCallbackWrapper.dispatchKeyEvent(Unknown Source:2)
com.android.internal.policy.DecorView.dispatchKeyEvent DecorView.java:387
android.view.ViewRootImpl$ViewPostImeInputStage.processKeyEvent ViewRootImpl.java:5460
android.view.ViewRootImpl$ViewPostImeInputStage.onProcess ViewRootImpl.java:5328
android.view.ViewRootImpl$InputStage.deliver ViewRootImpl.java:4835
android.view.ViewRootImpl$InputStage.onDeliverToNext ViewRootImpl.java:4888
android.view.ViewRootImpl$InputStage.forward ViewRootImpl.java:4854
android.view.ViewRootImpl$AsyncInputStage.forward ViewRootImpl.java:4994
android.view.ViewRootImpl$InputStage.apply ViewRootImpl.java:4862
android.view.ViewRootImpl$AsyncInputStage.apply ViewRootImpl.java:5051
android.view.ViewRootImpl$InputStage.deliver ViewRootImpl.java:4835
android.view.ViewRootImpl$InputStage.onDeliverToNext ViewRootImpl.java:4888
android.view.ViewRootImpl$InputStage.forward ViewRootImpl.java:4854
android.view.ViewRootImpl$InputStage.apply ViewRootImpl.java:4862
android.view.ViewRootImpl$InputStage.deliver ViewRootImpl.java:4835
android.view.ViewRootImpl.deliverInputEvent ViewRootImpl.java:7605
android.view.ViewRootImpl.doProcessInputEvents ViewRootImpl.java:7539
android.view.ViewRootImpl.enqueueInputEvent ViewRootImpl.java:7500
android.view.ViewRootImpl$ViewRootHandler.handleMessage ViewRootImpl.java:4608
android.os.Handler.dispatchMessage Handler.java:107
android.os.Looper.loop Looper.java:241
android.app.ActivityThread.main ActivityThread.java:7617
java.lang.reflect.Method.invoke(Native Method)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run RuntimeInit.java:492
com.android.internal.os.ZygoteInit.main ZygoteInit.java:941

Steps to Reproduce

Unknown

Expected Behavior

No crash

Actual Behavior

Java.Lang.IndexOutOfBoundsException: setSpan (16 ... 16) ends beyond length 15

Basic Information

• Version with issue: 4.8.0.1560
• Last known good version: n/a
• IDE: VS 2019 16.7
• Platform Target Frameworks:
  • iOS: -
  • Android: API Level 29 Q
  • UWP: -
• Android Support Library Version:
• Nuget Packages:
• Affected Devices: motorola one (Android 10), moto g(7) power (Android 10)

Reproduction Link

This has been observed via AppCenter and is demonstrably rare. Thus, I have no reproduction.

[Transis-Felipe]

I propose this update on Xamarin.Forms.Platform.Android\Renderers\EntryRenderer.cs:

if (text.Length < EditText.Length)
{
   EditText.SetSelection(text.Length);
}

or a Try/Catch like void UpdateCursorSelection()

				try
				{
					int start = GetSelectionStart();
					int end = GetSelectionEnd(start);

					EditText.SetSelection(start, end);
				}
				catch (System.Exception ex)
				{
					Internals.Log.Warning("Entry", $"Failed to set Control.Selection from CursorPosition/SelectionLength: {ex}");
				}