This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix Entry issue using TextColor and ClearButton in iOS < 13 #14566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
changed the title
|
I noticed #14526 fixed the same issues. We can merge 14526 and then, this PR will only include a test case. |
TBH I like this code just a tiny bit better, so merging this one :) |
rmarinho
added a commit
that referenced
this pull request
Sep 20, 2021
* Fix 4143: improved Span region calculation (#13348) fixes #4143 fixes #6992 fixes #11650 fixes #7655 fixes #11657 fixes #10520 fixes #4829 * improved span region calculation on android * Remove unused code * Nit: clean up comments * Wrap in ScrollView for small screen compatibility Co-authored-by: Tim Dittmar <Tim.Dittmar@Exxeta.com> Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com> * Only check for netfx when not in a wapproj (#14402) fixes #13957 * [macOS] Update Switch renderer (#14334) fixes #14313 * [macOS] Update Switch renderer #14313 * [macOS] Update Switch renderer #14313 * [Android] Fix to Issue Java.Lang.IndexOutOfBoundsException: setSpan (#12764) Fix to Issue #12762 * Update EntryRenderer.cs Fix to Issue #12762 Java.Lang.IndexOutOfBoundsException: setSpan (nn ... nn) ends beyond length n-1 * Fix to EntryRenderer.cs * Update EntryRenderer.cs * Update EntryRenderer.cs Co-authored-by: Rui Marinho <me@ruimarinho.net> * [Android] Fix ClearButton not working when changing the ClearButtonVisibility while the Entry field is focused (#13820) Fixes #13819 Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> * Automated dotnet-format update (#14404) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Automated dotnet-format update (#14405) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix memory leak (and some crashes) in ItemsViewController (iOS) (#14111) * add unit test * fix memory leak (and some crashes) in ItemsViewController (iOS) * Update ItemsViewController.cs Co-authored-by: Rui Marinho <me@ruimarinho.net> * Enable ScrollTo tests for Android, UWP; implement ScrollTo with group index for Android (#13007) * Remove inaccurate category * Enable ScrollTo tests for Android/UWP; Implement grouped ScrollTo for Android * Implement missing ScrollTo grouped item by index * Exempt 3788 test from UWP * Ignore test on UWP Co-authored-by: Rui Marinho <me@ruimarinho.net> * Fix type for case blueviolet (#14434) The 'v' in this case was uppercase causing this typeconverter to reject BlueViolet as a valid color value. Fixes #AB1286706 [XVS]XLS0431: Invalid value for property 'BackgroundColor': 'BlueViolet' * [iOS] Fix: CollectionView was not updating when it was invisible (#14384) * [iOS] Fix: CollectionView was not updating when it was invisible * [iOS] Fix: NSInternalInconsistencyException Reason: request for number of items in section X when there are only X sections in the collection view when NumberOfItemsInSection is invoked * Revert "[iOS] Fix: NSInternalInconsistencyException Reason: request for number of items in section X when there are only X sections in the collection view when NumberOfItemsInSection is invoked" This reverts commit 2343f15. * [iOS] Fix: Prevent NumberOfItemsInSection invoking if CollectionView is hidded to avoid "NSInternalInconsistencyException Reason: request for number of items in section X when there are only X sections" * [iOS] Scroll locked issue using SwipeView (#12758) * Fixed issue re-enabling the scroll * Added repro sample * Fixed also the swipe sensitive issue on iOS Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix removed shadow in Thumb setting a custom color (#13166) * [iOS] Fix crash/closing wrong modal with FormSheet and tap outside (#14527) * Add repro + fix * Update Issue12300.cs * [Core] SwipeItem Parent using SwipeView in DataTemplate (#13385) * Added repro sample * Fix the issue Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix Frame Background issue with transparent color (#14565) * Fix broken disabled Button visual state in UWP (#14567) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Update Device.Idiom when flipping tablet mode state (#13150) * [Android] Fix occasional wrong touch interception in SwipeView Content (#13732) * Fix wrong touch interception in SwipeView Content on Android * Updated swipe delta * Fix Entry issue using TextColor and ClearButton in iOS < 13 (#14566) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Fix issue using FormattedString and LineBreakMode on iOS (#14572) Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Align BarBackground behavior between Android and iOS. (#13503) * Automated dotnet-format update (#14570) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Android] Update gradients based on offset changes in Frame and BoxView (#11812) * Update gradients based on offset changes in Frame and BoxView on Android * Updated the sample to test also the BoxView Brush offsets * Fix NRE in ListView Command validation (#14580) * [iOS] Fix inability to check an initially disabled RadioButton after enabling it (#14545) * Listen for updates to IsEnabled on RadioButton to ensure that the tap gesture recogniser is added when the control is enabled * Update Issue14544.cs * Update test case Co-authored-by: Gerald Versluis <gerald@verslu.is> * Fix crash navigating in Shell (#14577) * Androidx bumps (#14506) * Update to Latest Android X Libraries * - fix android forwarders * Moar updates Co-authored-by: Gerald Versluis <gerald@verslu.is> * Validate issue 14433 (#14576) * Added repro sample * Updated sample Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * [iOS] Remove usage of System.Drawing types (#14571) * Run nightly also for 5.0.0 branch * Automated dotnet-format update (#14581) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Ordering children while adding (#8231) * Ordering children while adding * Abstract OrderElement * Re-order on runtime child addition and Tests * Runtime addition ensures Z Index * Stop performance measurement on return * Update VisualElementPackager.cs Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> * If stroke is null avoid render a shape stroke (#14587) * Fix broken Android platform tests (#14590) * Automated dotnet-format update (#14595) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [macOS] Fix RadioButton activated behaviour (#14139) * Respond to Activated event * Set initial control state based on element state * Revert "Set initial control state based on element state" This reverts commit 1bd1238. * CollectionView RemainingItemsThreshold implementation for UWP (#14202) * [Android] Fix building with Android stable bits (#14608) * Set java sdk path * Use class-parse Co-authored-by: Braini01 <T_Dittmar@web.de> Co-authored-by: Tim Dittmar <Tim.Dittmar@Exxeta.com> Co-authored-by: Rachel Kang <rachel.j.kang@gmail.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: MH Rastegari <42671084+mhrastegary77@users.noreply.github.com> Co-authored-by: Felipe Silveira <felipe@transis.com.br> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Jonathan Goyvaerts <jonathan.goyvaerts@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Mijieux <tmijieux@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Marco Goertz <mgoertz@microsoft.com> Co-authored-by: Kirill <rotorgames@bk.ru> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Lee Millward <lee.millward@gmail.com> Co-authored-by: Gerald Versluis <gerald@verslu.is> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Filip Navara <filip.navara@gmail.com> Co-authored-by: Shanmukha Ranganath <shanmukharanganath@gmail.com> Co-authored-by: Julio César Rocha <JunielKatarn@users.noreply.github.com> Co-authored-by: nk221 <kirill.n@gmail.com>
|
@jfversluis Hi Gerald. I like this code more too. It looks clean and more graceful But the solution to this issue is not as easy as it seems. When I was working on #14526, I found the same solution but the solution created another issue (see the gif below). iOS 12-13 iOS 14 This fix breaks color updating of the clear button on iOS < 14 because when I didn't find the more simple way except subscribing to a layer changing and change a button's color there. So, because of this, my code is not too clean. My PR (#14526) was tested on 12, 13, and 14 iOS. It works fine. A clear button's color is changing and there are no exceptions. @jfversluis I have updated my branch to 5.0.0. Please, re-open and take a look at my PR again. @jsuarezruiz Good work. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Entry issue using TextColor and ClearButton in iOS < 13
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery on iOS device or simulator and navigate to the issue 14523. Without exceptions, the test has passed.
PR Checklist