Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[UWP] Only reset ListView DataContext on INotifyCollectionChanged Reset #2453

Merged
merged 3 commits into from
Apr 16, 2018
Merged

[UWP] Only reset ListView DataContext on INotifyCollectionChanged Reset #2453

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9096593
Only reset the data content for ListView on a Reset event; fixes #2332
hartez Apr 13, 2018
f259ae2
Merge branch '3.0.0' into fix-gh2332
hartez Apr 13, 2018
1bbdd01
Fix formatting
hartez Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Xamarin.Forms.Platform.UAP/ListViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Collections.Specialized;
using System.ComponentModel;
using System.Linq;
using System.Threading.Tasks;
Expand Down Expand Up @@ -79,7 +81,12 @@ protected override void OnElementChanged(ElementChangedEventArgs<ListView> e)

void OnCollectionChanged(object sender, System.Collections.Specialized.NotifyCollectionChangedEventArgs e)
{
List.DataContext = new CollectionViewSource { Source = Element.ItemsSource, IsSourceGrouped = Element.IsGroupingEnabled };
if (e.Action == NotifyCollectionChangedAction.Reset)
{
List.DataContext =
new CollectionViewSource { Source = Element.ItemsSource, IsSourceGrouped = Element.IsGroupingEnabled };
}

List.UpdateLayout();
}

Expand Down