Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for NullReferenceException when ItemSource has item removed and a… #258

Merged
merged 2 commits into from Jul 18, 2016

Conversation

Projects
None yet
5 participants
@praga
Copy link
Contributor

commented Jul 15, 2016

Description of Change

In the SizeThatFits method of classViewTableCell added renderer.Element null check and return SizeF.Empty when the Element is null, so that it does not throw NullReferenceException when removing and re-adding another item to ListView

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

…nother inserted on iOS

@dnfclas

This comment has been minimized.

Copy link

commented Jul 15, 2016

Hi @praga, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

Update ViewCellRenderer.cs
Fix spacing issue
@rmarinho

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

👍

@rmarinho

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

Can you squash the commits? thanks

@jassmith

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2016

👍

@jassmith jassmith merged commit 5268d60 into xamarin:master Jul 18, 2016

@praga praga deleted the praga:fix-bugzilla42580 branch Jul 19, 2016

@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.