This repository has been archived by the owner on May 1, 2024. It is now read-only.
Better detection of IsCollapsed state/changes on iPad Master View Controller #8181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed _masterVisible to be calculated instead of just depending on Disappear/Appear events. There are a bunch of edge cases where Disappear and Appear aren't called.
The main theme of this code change is to keep the cross platform IsPresented better in lined with the reality of the native code. The way events are thrown are also fairly different between iOS 12 and iOS 13
Platforms Affected
Testing Procedure
Make sure to run all these tests on iOS 13 and iOS 12 as each platform runs fairly different
PR Checklist