Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Better detection of IsCollapsed state/changes on iPad Master View Controller #8181

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Oct 23, 2019

Description of Change

Fixed _masterVisible to be calculated instead of just depending on Disappear/Appear events. There are a bunch of edge cases where Disappear and Appear aren't called.

The main theme of this code change is to keep the cross platform IsPresented better in lined with the reality of the native code. The way events are thrown are also fairly different between iOS 12 and iOS 13

Platforms Affected

  • iOS

Testing Procedure

Make sure to run all these tests on iOS 13 and iOS 12 as each platform runs fairly different

  • run through Issue7556 and test as many combinations of rotating, pushing modal pages, rotating, and making sure Master button still works
  • Test through Bugzilla34632Test and make sure it works as expected

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added p/iOS 🍎 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Oct 23, 2019
@samhouts samhouts requested review from jsuarezruiz and removed request for rmarinho October 25, 2019 00:09
@samhouts samhouts assigned jsuarezruiz and unassigned rmarinho Oct 25, 2019
@samhouts samhouts changed the title Better detection of IsCollapsed state/changes on Master View Controller Better detection of IsCollapsed state/changes on iPad Master View Controller Oct 25, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Oct 28, 2019
@samhouts samhouts merged commit 1ecdf97 into 4.3.0 Oct 29, 2019
@samhouts samhouts deleted the fix_landscape_quirk branch October 29, 2019 00:42
@samhouts samhouts added this to the 4.3.0 milestone Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. iOS 13 p/iOS 🍎 p/tablet partner/cat 😻
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants