This repository has been archived by the owner on May 1, 2024. It is now read-only.
Cherry pick of iOS13 fixes for iPad #8201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… visible (#8164) * Don't force master closed when on split * - fix UI tests to correctly test for tablet * - remove extra code * - fix issue with rotation from Modal # Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs # Xamarin.Forms.Core.UITests.Shared/Utilities/AppExtensions.cs
# Conflicts: # Xamarin.Forms.Platform.iOS/Renderers/TabletMasterDetailRenderer.cs
jfversluis
approved these changes
Oct 28, 2019
...s.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs
Outdated
Show resolved
Hide resolved
...s.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs
Outdated
Show resolved
Hide resolved
samhouts
approved these changes
Oct 29, 2019
Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
samhouts
pushed a commit
that referenced
this pull request
Oct 29, 2019
* Don't force the Master page closed on disappear if it's set to always visible (#8164) * Don't force master closed when on split * - fix UI tests to correctly test for tablet * - remove extra code * - fix issue with rotation from Modal # Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/ScreenshotConditionalApp.cs # Xamarin.Forms.Core.UITests.Shared/Utilities/AppExtensions.cs * Better detect IsCollapsed state/changes on master # Conflicts: # Xamarin.Forms.Platform.iOS/Renderers/TabletMasterDetailRenderer.cs * - fix target for ios * - fix override * - helpers * Apply suggestions from code review Co-Authored-By: Gerald Versluis <gerald.versluis@microsoft.com>
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Cherry pick of
#8164
#8181
Testing Procedure
PR Checklist