This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Xaml] Create value from positional argument text of markup extension #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior introduced with this change conforms to the description of [MS-XAML-2009] page 80 and 81.
StephaneDelcroix
approved these changes
Dec 20, 2019
samhouts
approved these changes
Jan 1, 2020
| return new Property { last = next == '}', name = name, strValue = str_value, value = value }; | ||
| } | ||
|
|
||
| private Property ParsePropertyExpression(string prop, IServiceProvider serviceProvider, ref string remaining) |
There was a problem hiding this comment.
Suggested change
| private Property ParsePropertyExpression(string prop, IServiceProvider serviceProvider, ref string remaining) | |
| Property ParsePropertyExpression(string prop, IServiceProvider serviceProvider, ref string remaining) |
| } | ||
|
|
||
| protected string GetNextPiece(IServiceProvider serviceProvider, ref string remaining, out char next) | ||
| private string GetNextPiece(IServiceProvider serviceProvider, ref string remaining, out char next) |
There was a problem hiding this comment.
Suggested change
| private string GetNextPiece(IServiceProvider serviceProvider, ref string remaining, out char next) | |
| string GetNextPiece(IServiceProvider serviceProvider, ref string remaining, out char next) |
samhouts
added
the
approved
This was referenced Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The behavior introduced with this change conforms to the description of
[MS-XAML-2009] page 80 and 81.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Run the automated tests.
PR Checklist