Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Shell flyout menu not selected item with ripple effect #707

Open
1 of 2 tasks
ghost opened this issue Dec 29, 2020 · 6 comments
Open
1 of 2 tasks

[Bug] Shell flyout menu not selected item with ripple effect #707

ghost opened this issue Dec 29, 2020 · 6 comments
Labels
a/TouchEffect bug Something isn't working. Breaky break. s/unverified This issue needs verification/reproduction by a team member. PRs cannot be accepted/merged.

Comments

@ghost
Copy link

ghost commented Dec 29, 2020

Description

Hi, I would like to ask if it is possible to apply the ripple effect to Shell FlyoutItem. The ripple effect works, but the menu item does not work, you cannot change the page. Without ripple effect, the transition to the page works. Advise if I'm making a mistake somewhere. I will be happy for any advice.

Steps to Reproduce

  1. Create a Shell project
  2. Create ItemTemplate in AppShell
  3. Add a ripple effect to the DataTemplate
    xct:TouchEffect.NativeAnimationColor="Red"
    xct:TouchEffect.NativeAnimation="True"
<FlyoutItem Title="Item 1"> 
      <Shell.ItemTemplate> 
            <DataTemplate> 
                  <ContentView> 
                        <Grid HeightRequest="50" 
                            xct:TouchEffect.NativeAnimation="True" 
                            xct:TouchEffect.NativeAnimationColor="Red"> 
                        </Grid> 
                  </ContentView> 
            </DataTemplate> 
      </Shell.ItemTemplate> 
<ShellContent Route="HomePage" ContentTemplate="{DataTemplate local:HomePage}" /> 
</FlyoutItem>

Expected Behavior

Ripple effect and go to the selection page from the shell menu.

Actual Behavior

The ripple effect works, switching to another page does not work when selecting from the menu.

Platforms

  • Android
  • iOS

Basic Information

Workaround

Reproduction imagery

ezgif com-gif-maker (1)

Reproduction Link

@ghost ghost added bug Something isn't working. Breaky break. s/unverified This issue needs verification/reproduction by a team member. PRs cannot be accepted/merged. labels Dec 29, 2020
@pictos
Copy link
Contributor

pictos commented Dec 29, 2020

@ORRNY66 I think that you want to report this bug on XF repo, right?

@ghost
Copy link
Author

ghost commented Dec 30, 2020

@pictos
Copy link
Contributor

pictos commented Jan 1, 2021

Thanks @ORRNY66, I'll close this so.

@pictos pictos closed this as completed Jan 1, 2021
@hartez
Copy link

hartez commented Jan 8, 2021

@pictos

I whipped up a repro for this - one of the flyout items (About) has the touch effect applied, and the other (Browse) does not. The flyout item without the touch effect works fine; the one with the touch effect does not work. Is there something special I need to do so that the touch effect passes the tapped event through? If not, I think this is a bug with the touch effect.

_13253 Repro.zip

@pictos
Copy link
Contributor

pictos commented Jan 8, 2021

@hartez I'm sorry I didn't see that xct effect :/ I'll reopen this one and investigate better.

@pictos pictos reopened this Jan 8, 2021
@sthewissen sthewissen changed the title Shell flyout menu not selected item with ripple effect [Bug] Shell flyout menu not selected item with ripple effect Jan 12, 2021
@isness
Copy link

isness commented Aug 5, 2021

Has anyone found a workaround? Is it even possible to implement any touch effects on flyouts in some other way?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/TouchEffect bug Something isn't working. Breaky break. s/unverified This issue needs verification/reproduction by a team member. PRs cannot be accepted/merged.
Projects
None yet
Development

No branches or pull requests

5 participants