Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] [XPlat] Add support for iOS 12.5 #1074

Merged
merged 4 commits into from
Jan 14, 2021
Merged

[EN] [XPlat] Add support for iOS 12.5 #1074

merged 4 commits into from
Jan 14, 2021

Conversation

mattleibow
Copy link
Collaborator

@mattleibow mattleibow commented Jan 12, 2021

iOS 12.5 Support

This PR adds the support for iOS 12.5 notifications. To enable this platform, no actual code needs to change. This is done by leveraging the ScheduleFetch method to determine which task registration method to use - either BGTask or the new way. This method is actually called by Init, so it happens early on.

IsSupported

On platforms that do not support EN, such as iOS 10 or iOS 13.2, then it will now throw. To detect these scenarios, there is a new property IsSupported that can be used to display messages to the user. If it is true, then it does not guarantee that everything is ready to be used, but if it is false, then it is guaranteed that EN cannot be used.

The reason for this is that it will typically return true, and then if the user denies permissions or (on Android) GPS is out of date, or on iOS there is some extra criteria. These will be handled by the normal exceptions (unchanged). When this returns false, it means that there is no EN support at all. Either no APIs or GPS explicitly indicated that there is no EN support on the device.

If there is a case where this property is returning true and it can be pre-determined that it should return false, feel free to open an issue and I will try make sure we handle those extra cases.

@mattleibow
Copy link
Collaborator Author

This is the xplat changes for #1066 and requires #1072

@mattleibow mattleibow marked this pull request as draft January 13, 2021 11:55
@mattleibow mattleibow marked this pull request as ready for review January 14, 2021 00:08
@mattleibow mattleibow merged commit ae76460 into master Jan 14, 2021
@mattleibow mattleibow deleted the dev/en-ios-12.5 branch January 14, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant