Found bug - you code does not return shader logs

[thethereza]

You call getprograminfolog instead of getshaderinfolog. here's the updated function (found in GLProgram.cs) that fixes the bug:

string getLog (int obj) {
  string log;
  if (GL.IsShader( obj )) {
    log = GL.GetShaderInfoLog( obj );
  } else {
    log = GL.GetProgramInfoLog (obj);
  }

  return log;
}

[XamarinTrainers]

Thanks! Mike, can you fix this, please?

On Jul 10, 2013, at 2:32 PM, thethereza notifications@github.com wrote:

You call getprograminfolog instead of getshaderinfolog. here's the updated function (found in GLProgram.cs) that fixes the bug:

string getLog (int obj) {
string log;
if (GL.IsShader( obj )) {
log = GL.GetShaderInfoLog( obj );
} else {
log = GL.GetProgramInfoLog (obj);
}

return log;
}
—
Reply to this email directly or view it on GitHub.

[mikebluestein]

Which sample is this from?

[thethereza]

Sorry, I added the comment while looking at the broken app, figured git would associate the two. git sucks.

It's found in https://github.com/xamarin/monotouch-samples/tree/master/OpenGL/OpenGLES20Example -- and having the shader logs working was key! The rest of the code looks good, though it would be awesome if you added support for the multisampling anti-aliasing. I tried to do it but couldn't notice a difference / get it to work.