ConstraintGear2D: AccessViolationException when trying to add it to the node

[EgorBo]

32_Urho2DConstraints C# (Line 344)
someNode.CreateComponent()
or
someNode.AddComponent(new ConstraintGear2D(Context));

throw AccessViolationException

[migueldeicaza]

Please provide a stack trace

[EgorBo]

@migueldeicaza looks like it caused by overflow of StringHash.Code field (it should be uint instead of int) because now for that specific class (ConstraintGear2D) the StringHash LookupStringHash returns hash with a negative big code.

[EgorBo]

I've just checked - ConstraintGear2D::GetTypeStatic() returns 4159594590 (almost twice larger than Int32.MaxValue).
Same crash happens for several types (samples).

[migueldeicaza]

I am confused, can you produce a small reproduction test case?

[EgorBo]

@migueldeicaza
um...
just execute this in C#: (Samples project, Program.cs)

var valueMono = ConstraintGear2D.TypeStatic.Code;

valueMono is -135372706
same code in C++

auto valueCpp = ConstraintGear2D::GetTypeStatic();

valueCpp is 4159594590

but they should be the same. that's because of int type of Code field in StringHash instead of uint (used in C++ version).

[migueldeicaza]

They are internally the same value. Both -135372706 and 4159594590 are the same bit pattern (0xf7ee605e).

So the question is: how do I reproduce the crash, not how do I reproduce the two values rendering differently.

[EgorBo]

Oh, you are right, they are the same. let me collect the stacktrace.

[EgorBo]

I've filed an issue - #54

[EgorBo]

closing with #54 with fix 85b3fc0 fix is verified.