[Bug] Resx files don't work with Android App Bundle #3596

DiamondKesha · 2019-09-06T11:32:21Z

Description

If use Android App Bundle, then AppResource.de.resx and other don't work, but AppResource.resx work.
I use - this example

Steps to Reproduce

Add <AndroidPackageFormat>aab</AndroidPackageFormat> in project.csproj

Expected Behavior

Changing the language in the program

Actual Behavior

The language in the program should change, but it does not change.

Basic Information

Platform Target Frameworks: 5.0
Affected Devices: Samsung

losmacko · 2019-09-09T11:49:58Z

I have the same issue. Any workaround?

Fixes: dotnet#3596 Context: https://github.com/google/bundletool/blob/2e9ac4e628a690c0fce402548fe90c747c86533c/src/main/proto/config.proto#L22-L25 We got report of `.resx` files not working with Android App Bundles. Sure enough, when I tried the sample: https://docs.microsoft.com/en-us/samples/xamarin/xamarin-forms-samples/usingresxlocalization/ I was not seeing Spanish localization when running the app... So I pulled the app bundle from the device: > adb shell pm list packages -f | Select-String UsingResxLocalization.Android package:/data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk=UsingResxLocalization.Android > adb pull /data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk /data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk: 1 file pulled. 35.1 MB/s (12330445 bytes in 0.335s) And then discovered that all of the localization assemblies were compressed! > 7z l base.apk ... Size Compressed Name ----- ------------ ------------ 14848 14848 assemblies\UsingResxLocalization.dll 3584 1279 assemblies\de-CH\UsingResxLocalization.resources.dll 3584 1275 assemblies\de\UsingResxLocalization.resources.dll 3584 1306 assemblies\es\UsingResxLocalization.resources.dll 3584 1273 assemblies\fr\UsingResxLocalization.resources.dll 3584 1286 assemblies\id\UsingResxLocalization.resources.dll 3584 1348 assemblies\ja\UsingResxLocalization.resources.dll 3584 1280 assemblies\ms\UsingResxLocalization.resources.dll 3584 1302 assemblies\pt-BR\UsingResxLocalization.resources.dll 3584 1301 assemblies\pt\UsingResxLocalization.resources.dll 3584 1288 assemblies\zh-Hans\UsingResxLocalization.resources.dll 3584 1288 assemblies\zh-Hant\UsingResxLocalization.resources.dll Looking the file structure of the `base.apk`, we had an incorrect wildcard for `BundleConfig.json`: assemblies/* It needs to be `assemblies/**`, so sub-directories will work. I added a project with `.resx` files to `BundleToolTests` and some assertions to ensure all .NET assemblies remain uncompressed in Android App Bundles.

jonathanpeppers · 2019-09-09T18:29:23Z

I did not test this, but a theoretical workaround, would be to set .dll for the AndroidStoreUncompressedFileExtensions setting:

Fixes: #3596 Context: https://github.com/google/bundletool/blob/2e9ac4e628a690c0fce402548fe90c747c86533c/src/main/proto/config.proto#L22-L25 We got report of `.resx` files not working with Android App Bundles. Sure enough, when I tried the sample: https://docs.microsoft.com/en-us/samples/xamarin/xamarin-forms-samples/usingresxlocalization/ I was not seeing Spanish localization when running the app... So I pulled the app bundle from the device: > adb shell pm list packages -f | Select-String UsingResxLocalization.Android package:/data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk=UsingResxLocalization.Android > adb pull /data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk /data/app/UsingResxLocalization.Android-VGGyQ6woBTkNUy4HJ8WqmQ==/base.apk: 1 file pulled. 35.1 MB/s (12330445 bytes in 0.335s) And then discovered that all of the localization assemblies were compressed! > 7z l base.apk ... Size Compressed Name ----- ------------ ------------ 14848 14848 assemblies\UsingResxLocalization.dll 3584 1279 assemblies\de-CH\UsingResxLocalization.resources.dll 3584 1275 assemblies\de\UsingResxLocalization.resources.dll 3584 1306 assemblies\es\UsingResxLocalization.resources.dll 3584 1273 assemblies\fr\UsingResxLocalization.resources.dll 3584 1286 assemblies\id\UsingResxLocalization.resources.dll 3584 1348 assemblies\ja\UsingResxLocalization.resources.dll 3584 1280 assemblies\ms\UsingResxLocalization.resources.dll 3584 1302 assemblies\pt-BR\UsingResxLocalization.resources.dll 3584 1301 assemblies\pt\UsingResxLocalization.resources.dll 3584 1288 assemblies\zh-Hans\UsingResxLocalization.resources.dll 3584 1288 assemblies\zh-Hant\UsingResxLocalization.resources.dll Looking the file structure of the `base.apk`, we had an incorrect wildcard for `BundleConfig.json`: assemblies/* It needs to be `assemblies/**`, so sub-directories will work. I added a project with `.resx` files to `BundleToolTests` and some assertions to ensure all .NET assemblies remain uncompressed in Android App Bundles.

King-of-Spades · 2019-09-12T23:11:33Z

@jonathanpeppers Is the fix available yet in a Xamarin.Android release, or is that still pending?

jonathanpeppers · 2019-09-12T23:13:30Z

It should be in a future Visual Studio 2019 16.4 release. I don’t think the release date is public quite yet.

EmilAlipiev · 2019-09-23T13:26:26Z

Does this solution have any side effects? is it not increasing bundle size? if i am not mistaken dlls were compressed into apk but now not in aab. is it not a step back?

jonathanpeppers · 2019-09-23T13:37:16Z

DLLs are not compressed, because mmap is used to load them into memory directly from the APK.

I think we looked at allowing .NET assemblies to be compressed at one point, but it hurt startup performance.

brendanzagaeski · 2019-09-25T06:57:27Z

Release status update

A new Preview version has now been published that includes the fix for this item. The fix is not yet included in a Release version. I will update this item again when a Release version is available that includes the fix.

The fix is not yet available on macOS. I will update this item again when a Preview version with the fix is available on macOS.

Fix included in Xamarin.Android 10.0.99.100.

Fix included on Windows in Visual Studio 2019 version 16.4 Preview 1. To try the Preview version that includes the fix, check for the latest updates in Visual Studio Preview.

Fix not yet available on macOS.

thisisthekap · 2019-10-04T07:13:32Z

@brendanzagaeski As we are quite desperately looking forward to AAB publishing (mainly because of download sizes), we would appreciate it to see this issue in a hotfix Version of Xamarin.Android, as this issue is also listed in the "Known Issues" section of Xamarin.Android 10.0.0.43.

jonathanpeppers · 2019-10-04T11:36:56Z

@thisisthekap did the workaround work? #3596 (comment)

mvxproject · 2019-10-15T09:37:33Z

I Confirm, the workaround works, mp3 files must also be included to work properly.

jonathanpeppers · 2019-10-15T13:35:04Z

@lahna200 there are 2 fixes for app bundles & compression in the next release (Xamarin.Android 10.1), but I bet this one will fix the mp3 issue: #3604

brendanzagaeski · 2019-10-18T23:18:54Z

Release status update

A new Preview version has now been published for macOS that includes the fix for this item.

Fix included in Xamarin.Android 10.1.0.1.

Fix included on macOS in Visual Studio 2019 for Mac version 8.4 Preview 1. To try the Preview version that includes the fix, check for the latest updates on the Preview updater channel.

EmilAlipiev · 2019-10-20T00:22:30Z

Is there already a documentation or article about how to achieve app bundles step by step?

andrewleader · 2019-11-01T14:00:39Z

I'm also blocked on this, eagerly waiting for the stable channel release fix to hit Azure DevOps so I can build in the cloud again! Building locally using the preview in the meantime.

jonathanpeppers · 2019-11-01T15:12:20Z

@andrewleader there is a workaround for this one: #3596 (comment)

brendanzagaeski · 2019-12-04T02:22:20Z

Release status update

A new Release version has now been published on Windows that includes the fix for this item. The fix is not yet published in a Release version on macOS. I will update this item again when a Release version is available on macOS that includes the fix.

Fix included in Xamarin.Android 10.1.0.30.

Fix included on Windows in Visual Studio 2019 version 16.4. To get the new version that includes the fix, check for the latest updates or install the latest version from https://visualstudio.microsoft.com/downloads/.

(Fix also included on macOS in Visual Studio 2019 for Mac version 8.4 Preview 2.1 and higher. To try the Preview version that includes the fix, check for the latest updates on the Preview updater channel.)

brendanzagaeski · 2020-01-08T21:17:08Z

Release status update

A new Release version has now been published on macOS that includes the fix for this item.

Fix included in Xamarin.Android 10.1.1.0.

Fix included on macOS in Visual Studio 2019 for Mac version 8.4. To get the new version that includes the fix, check for the latest updates on the Stable updater channel.

(Fix also included on Windows in Visual Studio 2019 version 16.4 and higher. To get the new version that includes the fix, check for the latest updates or install the latest version from https://visualstudio.microsoft.com/downloads/.)

acuntex · 2020-05-28T19:16:20Z

@brendanzagaeski Does either not work or is a regressed bug.

When starting the app in a German Simulator all texts show correctly in German.
When bundling as aab and uploading to the store all texts are again English on a German device.

Anyone else experiencing this?

brendanzagaeski · 2020-05-28T19:23:24Z

@acuntex, thanks for the heads-up! If are using Xamarin.Android 10.3 in Visual Studio 2019 version 16.6 or Visual Studio 2019 for Mac version 8.6, one likely possible cause is #4664. If the workaround mentioned in that item does not resolve the issue for your project, then if you might be able to submit a new issue that has the diagnostic MSBuild output from your project zipped and attached so the team can take a look, that would be perfect. Thanks in advance!

acuntex · 2020-05-28T19:28:43Z

I can confirm that the workaround from #4664 worked.
Thanks!

samhouts transferred this issue from xamarin/Xamarin.Forms Sep 6, 2019

jonathanpeppers self-assigned this Sep 9, 2019

jonathanpeppers added this to the Under Consideration milestone Sep 9, 2019

jonathanpeppers added the Area: App+Library Build Issues when building Library projects or Application projects. label Sep 9, 2019

jonathanpeppers mentioned this issue Sep 9, 2019

Android App Bundle (.aab) Support microsoft/appcenter#194

Closed

jonathanpeppers mentioned this issue Sep 9, 2019

[Xamarin.Android.Build.Tasks] fix resx files for aabs #3603

Merged

jonathanpeppers closed this as completed in #3603 Sep 9, 2019

brendanzagaeski modified the milestones: Under Consideration, d16-4 Sep 25, 2019

brendanzagaeski modified the milestones: d16-4, In preview: 10.1 (d16-4) Oct 18, 2019

huybuidac mentioned this issue Mar 25, 2020

[Android] Localization does not work properly with "Bundle assemblies into native code" option enabled xamarin/Xamarin.Forms#1595

Open

mattleibow mentioned this issue Nov 12, 2021

Multilingual App Toolkit without the nagging Android bug dotnet/maui#1780

Closed

sayed-alim mentioned this issue Nov 19, 2021

Resx files don't work with Android App Bundle in Release Mode #6513

Closed

ghost locked as resolved and limited conversation to collaborators Jun 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Resx files don't work with Android App Bundle #3596

[Bug] Resx files don't work with Android App Bundle #3596

DiamondKesha commented Sep 6, 2019

losmacko commented Sep 9, 2019

jonathanpeppers commented Sep 9, 2019

King-of-Spades commented Sep 12, 2019

jonathanpeppers commented Sep 12, 2019

EmilAlipiev commented Sep 23, 2019

jonathanpeppers commented Sep 23, 2019 •

edited

Loading

brendanzagaeski commented Sep 25, 2019

thisisthekap commented Oct 4, 2019

jonathanpeppers commented Oct 4, 2019

mvxproject commented Oct 15, 2019

jonathanpeppers commented Oct 15, 2019

brendanzagaeski commented Oct 18, 2019

EmilAlipiev commented Oct 20, 2019

andrewleader commented Nov 1, 2019

jonathanpeppers commented Nov 1, 2019

brendanzagaeski commented Dec 4, 2019

brendanzagaeski commented Jan 8, 2020

acuntex commented May 28, 2020

brendanzagaeski commented May 28, 2020

acuntex commented May 28, 2020

[Bug] Resx files don't work with Android App Bundle #3596

[Bug] Resx files don't work with Android App Bundle #3596

Comments

DiamondKesha commented Sep 6, 2019

Description

Steps to Reproduce

Expected Behavior

Actual Behavior

Basic Information

losmacko commented Sep 9, 2019

jonathanpeppers commented Sep 9, 2019

King-of-Spades commented Sep 12, 2019

jonathanpeppers commented Sep 12, 2019

EmilAlipiev commented Sep 23, 2019

jonathanpeppers commented Sep 23, 2019 • edited Loading

brendanzagaeski commented Sep 25, 2019

thisisthekap commented Oct 4, 2019

jonathanpeppers commented Oct 4, 2019

mvxproject commented Oct 15, 2019

jonathanpeppers commented Oct 15, 2019

brendanzagaeski commented Oct 18, 2019

EmilAlipiev commented Oct 20, 2019

andrewleader commented Nov 1, 2019

jonathanpeppers commented Nov 1, 2019

brendanzagaeski commented Dec 4, 2019

brendanzagaeski commented Jan 8, 2020

acuntex commented May 28, 2020

brendanzagaeski commented May 28, 2020

acuntex commented May 28, 2020

jonathanpeppers commented Sep 23, 2019 •

edited

Loading