Do not pass Proxy.NoProxy so that the system proxy settings are respected #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I'm the build bot for Xamarin. I need approval from a Xamarin team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
approve |
grendello
approved these changes
May 6, 2019
|
Would it be possible to merge this fix into branch d16-2 so it becomes available in the next Xamarin.Android 9.4 update? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
I added comments inline for clarification.
According to https://docs.oracle.com/javase/7/docs/api/java/net/URL.html#openConnection() passing Proxy.NoProxy tells the URL class to not use a proxy, regardless of system settings. Leaving the parameter out makes sure that system settings are used.