-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Fix up AndroidStoreUncompressedFileExtensions. #3968
Conversation
Should we have a unit test for this? :-D We could probably update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dellis1972 it looks like the PackagingTest.CheckIncludedNativeLibraries
test broke in the latest PR builds.
…nsions. Fixes dotnet#3962 Commit d20a991 fixed up an issue where `aapt2` was always compressing items even if they were defined in `AndroidStoreUncompressedFileExtensions`. However users are not always including a period in the values they place in that ItemGroup. In the Linked issue the user was using `tflite` rather than `.tflite` which `aapt2` is expecrting. So lets check to see if we have a `.` prefix and if not add one.
Unit test failure is un related. |
…nsions. (#3968) Fixes #3962 Commit d20a991 fixed up an issue where `aapt2` was always compressing items even if they were defined in `AndroidStoreUncompressedFileExtensions`. However users are not always including a period in the values they place in that ItemGroup. In the Linked issue the user was using `tflite` rather than `.tflite` which `aapt2` is expecrting. So lets check to see if we have a `.` prefix and if not add one. * Added Unit Test * Fixed Native Library Compression Method
Release status update A new Preview version has now been published that includes the fix from this item. The fix is not yet included in a Release version. I will update this item again when a Release version is available that includes the fix. Fix included in Xamarin.Android 10.2.0.84. Fix included on Windows in Visual Studio 2019 version 16.5 Preview 2. To try the Preview version that includes the fix, check for the latest updates in Visual Studio Preview. Fix included on macOS in Visual Studio 2019 for Mac version 8.5 Preview 1. To try the Preview version that includes the fix, check for the latest updates on the Preview updater channel. |
Release status update A new Release version has now been published on Windows that includes the fix from this item. The fix is not yet published in a Release version on macOS. I will update this item again when a Release version is available on macOS that includes the fix. Fix included in Xamarin.Android 10.2.0.100. Fix included on Windows in Visual Studio 2019 version 16.5. To get the new version that includes the fix, check for the latest updates or install the latest version from https://visualstudio.microsoft.com/downloads/. (Fix also included on macOS in Visual Studio 2019 for Mac version 8.5 Preview 1 and higher. To try the Preview version that includes the fix, check for the latest updates on the Preview updater channel.) |
Release status update A new Release version has now been published on macOS that includes the fix for this item. Fix included in Xamarin.Android 10.2.0.100. Fix included on macOS in Visual Studio 2019 for Mac version 8.5. To get the new version that includes the fix, check for the latest updates on the Stable updater channel. (Fix also included on Windows in Visual Studio 2019 version 16.5 and higher. To get the new version that includes the fix, check for the latest updates or install the latest version from https://visualstudio.microsoft.com/downloads/.) |
Fixes #3962
Commit d20a991 fixed up an issue where
aapt2
was always compressingitems even if they were defined in
AndroidStoreUncompressedFileExtensions
.However users are not always including a period in the values they
place in that ItemGroup. In the Linked issue the user was using
tflite
rather than.tflite
whichaapt2
is expecrting.So lets check to see if we have a
.
prefix and if not add one.