Skip to content

Commit

Permalink
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticati…
Browse files Browse the repository at this point in the history
…onembeddedui-b2-b3

[LocalAuthenticationEmbeddedUI] Update bindings for Xcode 13.0 beta 2 and 3
  • Loading branch information
rachelkang committed Sep 1, 2021
2 parents 4380161 + f7efc61 commit 3fc6b06
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/frameworks.sources
Expand Up @@ -1975,6 +1975,7 @@ MAC_FRAMEWORKS = \
JavaScriptCore \
LinkPresentation \
LocalAuthentication \
LocalAuthenticationEmbeddedUI \
MailKit \
MapKit \
MediaAccessibility \
Expand Down
38 changes: 38 additions & 0 deletions src/localauthenticationembeddedui.cs
@@ -0,0 +1,38 @@
//
// LocalAuthenticationEmbeddedUI C# bindings
//
// Authors:
// Rachel Kang <rachelkang@microsoft.com>
//
// Copyright 2021 Microsoft Corporation All rights reserved.
//

using System;
using ObjCRuntime;
using Foundation;
using AppKit;
using CoreGraphics;
using LocalAuthentication;

namespace LocalAuthenticationEmbeddedUI {

[NoWatch, NoTV, NoiOS, NoMacCatalyst, Mac (12,0)]
[BaseType (typeof (NSView))]
interface LAAuthenticationView
{
[Export ("initWithFrame:")]
IntPtr Constructor (CGRect frameRect);

[Export ("initWithContext:")]
IntPtr Constructor (LAContext context);

[Export ("initWithContext:controlSize:")]
IntPtr Constructor (LAContext context, NSControlSize controlSize);

[Export ("context")]
LAContext Context { get; }

[Export ("controlSize")]
NSControlSize ControlSize { get; }
}
}
@@ -1,3 +1,4 @@
## No LocalAuthentication support for Catalyst
!missing-selector! LAAuthenticationView::context not bound
!missing-selector! LAAuthenticationView::controlSize not bound
!missing-selector! LAAuthenticationView::initWithContext: not bound
Expand Down
5 changes: 0 additions & 5 deletions tests/xtro-sharpie/macOS-LocalAuthenticationEmbeddedUI.todo

This file was deleted.

1 change: 1 addition & 0 deletions tools/common/Frameworks.cs
Expand Up @@ -262,6 +262,7 @@ public Framework Find (string framework)
{ "AdServices", "AdServices", 11,1 },

{ "Chip", "CHIP", 12, 0 },
{ "LocalAuthenticationEmbeddedUI", "LocalAuthenticationEmbeddedUI", 12, 0 },
{ "MailKit", "MailKit", 12, 0 },
{ "MetricKit", 12, 0 },
{ "Phase", "PHASE", 12, 0 },
Expand Down

5 comments on commit 3fc6b06

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ [CI Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

🎉 All 249 tests passed 🎉

Pipeline on Agent XAMBOT-1036.BigSur'
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticationembeddedui-b2-b3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticationembeddedui-b2-b3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticationembeddedui-b2-b3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticationembeddedui-b2-b3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
Merge pull request #12535 from rachelkang/xcode13.0-localauthenticationembeddedui-b2-b3

Please sign in to comment.