Skip to content

Commit

Permalink
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#1…
Browse files Browse the repository at this point in the history
…2598)

Web documentation mention them to be available. Introspection disagree.

Since they are all related to a single `VideoCallSupport` category, this
feature is likely not available to Catalyst.
  • Loading branch information
spouliot committed Sep 1, 2021
1 parent 31e4c05 commit 4380161
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/avkit.cs
Original file line number Diff line number Diff line change
Expand Up @@ -842,15 +842,18 @@ interface AVPictureInPictureControllerContentSource

// interface AVPictureInPictureControllerContentSource_VideoCallSupport
[NoWatch, NoTV, NoMac]
[NoMacCatalyst] // doc as available, intro fails on macOS 12 beta 6
[Export ("initWithActiveVideoCallSourceView:contentViewController:")]
IntPtr Constructor (UIView sourceView, AVPictureInPictureVideoCallViewController contentViewController);

[NullAllowed]
[NoWatch, NoTV, NoMac]
[NoMacCatalyst] // doc as available, intro fails on macOS 12 beta 6
[Export ("activeVideoCallSourceView", ArgumentSemantic.Weak)]
UIView ActiveVideoCallSourceView { get; }

[NoWatch, NoTV, NoMac]
[NoMacCatalyst] // doc as available, intro fails on macOS 12 beta 6
[Export ("activeVideoCallContentViewController")]
AVPictureInPictureVideoCallViewController ActiveVideoCallContentViewController { get; }

Expand Down
5 changes: 5 additions & 0 deletions tests/xtro-sharpie/MacCatalyst-AVKit.ignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,8 @@
!extra-enum-value! Managed value -1100 for AVKitError.ContentRatingUnknown not found in native headers
!extra-enum-value! Managed value -1101 for AVKitError.ContentDisallowedByPasscode not found in native headers
!extra-enum-value! Managed value -1102 for AVKitError.ContentDisallowedByProfile not found in native headers

## `VideoCallSupport` category introspection failures on MacCatalyst 15
!missing-selector! AVPictureInPictureControllerContentSource::activeVideoCallContentViewController not bound
!missing-selector! AVPictureInPictureControllerContentSource::activeVideoCallSourceView not bound
!missing-selector! AVPictureInPictureControllerContentSource::initWithActiveVideoCallSourceView:contentViewController: not bound

5 comments on commit 4380161

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ [CI Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

Packages generated

View packages

🎉 All 249 tests passed 🎉

Pipeline on Agent XAMBOT-1030.BigSur'
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#12598)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests tvOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#12598)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Tests were not ran (VSTS: device tests iOS). ⚠️

Results were skipped for this run due to provisioning problems Azure Devops. Please contact the bot administrator.

Pipeline on Agent
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#12598)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS M1 - Mac Big Sur (11.5) ❌

Tests failed on M1 - Mac Big Sur (11.5).

Failed tests are:

  • xammac_tests

Pipeline on Agent
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#12598)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests passed on macOS Mac Mojave (10.14) ✅

Tests passed

All tests on macOS X Mac Mojave (10.14) passed.

Pipeline on Agent
[avkit] Fix VideoCallSupport category failure on MacCatalyst 15 (#12598)

Please sign in to comment.