[CHIP] Add support for Xcode13 beta2. #12025

mandel-macaque · 2021-06-25T21:22:31Z

No description provided.

src/chip.cs

tj-devel709 · 2021-06-25T21:31:17Z

src/chip.cs

+		[DesignatedInitializer]
+		IntPtr Constructor (ChipDevice device, byte endpoint, DispatchQueue queue);
+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]


When should we use this ResultTypeName with Async?

It is related when the handler returns more than one value:

delegate void ChipResponseHandler ([NullAllowed] NSError error, [NullAllowed] NSDictionary data);

The generator will tell you.

tj-devel709 · 2021-06-25T21:32:06Z

src/chip.cs

+	}
+
+	[Mac (12,0), Watch (8,0), TV (15,0), iOS (15,0), MacCatalyst (15,0)]
+	[BaseType (typeof(ChipCluster), Name="CHIPBinding")]


Suggested change

[BaseType (typeof(ChipCluster), Name="CHIPBinding")]

[BaseType (typeof (ChipCluster), Name="CHIPBinding")]

same

src/chip.cs

tj-devel709

Other than the missing spaces in the basetypes, it looks good to me!

vs-mobiletools-engineering-service2 · 2021-06-26T02:32:43Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

12 tests failed, 77 tests passed.

Failed tests

framework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: BuildFailure
dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
dont link/watchOS 32-bits - simulator/Release: BuildFailure
link all/watchOS 32-bits - simulator/Release: BuildFailure
link sdk/watchOS 32-bits - simulator/Release: BuildFailure
MSBuild tests/Integration: Failed (Execution failed with exit code 45)
MTouch tests/NUnit: Failed (Execution failed with exit code 27)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 1d6fac0 into b1e8b29

src/chip.cs

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2021-06-28T15:46:44Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 805652d into 870ffa0

…n-macios into chip-xcode13-beta1

vs-mobiletools-engineering-service2 · 2021-06-28T16:44:34Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge e1a541e into 3240249

rolfbjarne · 2021-06-28T13:09:25Z

tests/introspection/ApiProtocolTest.cs

+#if !MONOMAC
+				if (t.Namespace == "Chip" && Runtime.Arch == Arch.SIMULATOR) // namespace not present in sims as of Xcode13 beta 1
+					continue;
+#endif
+


This logic should go in the Skip method, possibly in the MacApiProtocolTest subclass.

rolfbjarne · 2021-06-28T16:49:35Z

src/chip.cs

+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+


The [Async] attribute should be one liner lower.

dalexsoto

After the comments are addressed 👍

dalexsoto · 2021-06-28T18:36:25Z

src/chip.cs

+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+		[Export ("disableNetwork:breadcrumb:timeoutMs:responseHandler:")]
+		void DisableNetwork (NSData networkID, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);


There are other ID that needs to be Id

Suggested change

void DisableNetwork (NSData networkID, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);

void DisableNetwork (NSData networkId, ulong breadcrumb, uint timeoutMs, ChipResponseHandler responseHandler);

dalexsoto · 2021-06-28T18:43:01Z

src/chip.cs

+		bool PairDevice (ulong deviceID, string address, ushort port, ushort discriminator, uint setupPinCode, [NullAllowed] out NSError error);
+
+		[Export ("pairDeviceWithoutSecurity:address:port:error:")]
+		bool PairDeviceWithoutSecurity (ulong deviceID, string address, ushort port, [NullAllowed] out NSError error);


Same search and replace.

Suggested change

bool PairDeviceWithoutSecurity (ulong deviceID, string address, ushort port, [NullAllowed] out NSError error);

bool PairDeviceWithoutSecurity (ulong deviceId, string address, ushort port, [NullAllowed] out NSError error);

src/chip.cs

Co-authored-by: Alex Soto <alex@alexsoto.me>

vs-mobiletools-engineering-service2 · 2021-06-29T03:59:41Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

11 tests failed, 78 tests passed.

Failed tests

monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
interdependent-binding-projects/iOS Unified 64-bits - simulator/Debug: BuildFailure
dont link/iOS Unified 64-bits - simulator/Release: BuildFailure
dont link/watchOS 32-bits - simulator/Release: BuildFailure
link all/watchOS 32-bits - simulator/Release: BuildFailure
link sdk/watchOS 32-bits - simulator/Release: BuildFailure
MSBuild tests/Integration: Failed (Execution failed with exit code 45)
MTouch tests/NUnit: Failed (Execution failed with exit code 27)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge e416449 into e2a92c1

…n-macios into chip-xcode13-beta1

rolfbjarne · 2021-06-29T18:42:09Z

tools/common/Target.cs

@@ -222,6 +222,7 @@ public void GatherFrameworks ()
 						case "Metal":
 						case "MetalKit":
 						case "MetalPerformanceShaders":
+						case "CHIP":


@dalexsoto out of curiosity, why doesn't the default case handle this?

xamarin-macios/tools/common/Target.cs

Lines 251 to 258 in 401befe

if (App.IsSimulatorBuild && !App.IsFrameworkAvailableInSimulator (framework.Name)) {

if (App.LinkMode != LinkMode.None) {

ErrorHelper.Warning (5223, Errors.MX5223, framework.Name, App.PlatformName);

} else {

Driver.Log (3, Errors.MX5223, framework.Name, App.PlatformName);

}

continue;

}

@rolfbjarne good question, I did not have a close look at it I wonder if there is a casing issue somewhere @mandel-macaque looks like we'll need to check deeper

I'm looking atm.

vs-mobiletools-engineering-service2 · 2021-06-30T00:55:57Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 85 tests passed.

Failed tests

monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2451 Passed: 2389 Inconclusive: 10 Failed: 1 Ignored: 61)
monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2488 Inconclusive: 36 Failed: 1 Ignored: 133)
monotouch-test/tvOS - simulator/Debug: Failed
Xtro/Mac: BuildFailure

Pipeline on Agent XAMBOT-1104.BigSur'
Merge c2c366c into a64b030

vs-mobiletools-engineering-service2 · 2021-06-30T21:39:45Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 68837db into 0bfb745

[CHIP] Add support for Xcode13 beta1.

0eea0e1

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jun 25, 2021

mandel-macaque requested review from rolfbjarne and spouliot as code owners June 25, 2021 21:22

Merge branch 'main' into chip-xcode13-beta1

1d6fac0

tj-devel709 reviewed Jun 25, 2021

View reviewed changes