Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Versions-ios.plist] watchOS started at 1.0 #1328

Merged
merged 1 commit into from
Dec 13, 2016
Merged

[Versions-ios.plist] watchOS started at 1.0 #1328

merged 1 commit into from
Dec 13, 2016

Conversation

VincentDondain
Copy link
Contributor

  • The WatchKit App on a watchOS 1 project has a version of 1.0 (the IDE needs that).
  • We still have a watchOS 1 template.

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

rolfbjarne
rolfbjarne requested changes Dec 12, 2016
View reviewed changes
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, because code-wise we only care about WatchKit 2 extensions (since WatchKit 1 extensions are technically iOS extensions, not watchOS extensions).

IMHO the IDEs should hard-code whatever they need for WatchKit 1 extensions (also because nothing will ever change there, so hard-coding is still future-proof).

@VincentDondain
[Versions-ios.plist] watchOS started at 1.0
bb11c53 
- The WatchKit App on a watchOS 1 project has a version of 1.0 (the IDE needs that).
- We still have a watchOS 1 template.
- Use MIN_WATCH_OS_VERSION instead of MIN_WATCHOS_SDK_VERSION.
- iOS com.apple.watchkit is 8.2 not 8.0
- Added watchOS com.apple.watchkit (2.0).
- Fixed typo in versions-check.csharp.
@VincentDondain
Copy link
Contributor Author

@rolfbjarne updated all the things, it should match our conversation, please re-check (;

@monojenkins
Copy link
Collaborator

Build failure

@VincentDondain
Copy link
Contributor Author

build

@monojenkins
Copy link
Collaborator

Build failure

@rolfbjarne
Copy link
Member

Test failure is unrelated (ibtool hang due to bug #46097).

@rolfbjarne rolfbjarne merged commit 445877c into xamarin:master Dec 13, 2016
VincentDondain added a commit to VincentDondain/xamarin-macios that referenced this pull request Dec 14, 2016
@VincentDondain
[Versions-ios.plist] watchOS started at 1.0 (xamarin#1328)
adb5ca4 
- The WatchKit App on a watchOS 1 project has a version of 1.0 (the IDE needs that).
- We still have a watchOS 1 template.
- Use MIN_WATCH_OS_VERSION instead of MIN_WATCHOS_SDK_VERSION.
- iOS com.apple.watchkit is 8.2 not 8.0
- Added watchOS com.apple.watchkit (2.0).
- Fixed typo in versions-check.csharp.
rolfbjarne pushed a commit that referenced this pull request Dec 15, 2016
@VincentDondain @rolfbjarne
[Versions-ios.plist] watchOS started at 1.0 (#1328) (#1347)
f2bc819 
- The WatchKit App on a watchOS 1 project has a version of 1.0 (the IDE needs that).
- We still have a watchOS 1 template.
- Use MIN_WATCH_OS_VERSION instead of MIN_WATCHOS_SDK_VERSION.
- iOS com.apple.watchkit is 8.2 not 8.0
- Added watchOS com.apple.watchkit (2.0).
- Fixed typo in versions-check.csharp.
rolfbjarne added a commit that referenced this pull request Jan 10, 2019
@rolfbjarne
Bump maccore to get an additional fix.
fedcbfa 
Commit list for xamarin/maccore:

* xamarin/maccore@83bd122dd3 [install-qa-provisioning-profiles] Make sure we find pencil_pusher. (#1328)
* xamarin/maccore@2df4e9934d Merge pull request #1327 from xamarin/swift-o-matic-override-init
* xamarin/maccore@a95796666b Bump to ignore stubbed constructors.

Diff: xamarin/maccore@6324465...83bd122
rolfbjarne added a commit that referenced this pull request Jan 11, 2019
@rolfbjarne
Bump maccore to get fix for maccore#1325. (#5366)
0496a39 
* Bump maccore to get fix for maccore#1325.

Commit list for xamarin/maccore:

* xamarin/maccore@6324465797 [install-qa-provisioning-profiles] Make sure we find ruby and its related tools. (#1324)
[...] Many irrelevant SoM commits [...]

Diff: xamarin/maccore@e3d92b5...6324465

* Bump maccore to get an additional fix.

Commit list for xamarin/maccore:

* xamarin/maccore@83bd122dd3 [install-qa-provisioning-profiles] Make sure we find pencil_pusher. (#1328)
* xamarin/maccore@2df4e9934d Merge pull request #1327 from xamarin/swift-o-matic-override-init
* xamarin/maccore@a95796666b Bump to ignore stubbed constructors.

Diff: xamarin/maccore@6324465...83bd122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VincentDondain @monojenkins @rolfbjarne @spouliot @dnfclas